Bug 759153

Summary:	Configuration files need better validation and error reporting.
Product:	[Retired] Pulp	Reporter:	Jeff Ortel <jortel>
Component:	z_other	Assignee:	Jeff Ortel <jortel>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	low	Docs Contact:
Priority:	low
Version:	unspecified	Keywords:	Triaged
Target Milestone:	---
Target Release:	Sprint 30
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Jeff Ortel 2011-12-01 14:35:42 UTC

Description of problem:

The pulp configuration files need better validation and error reporting.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. On the client: change the name of a property or section in either consumer.conf or admin.conf
2. Observe errors in the log.
3.
  
Actual results:

Very cryptic error or non-deterministic behaviour.

Expected results:

Meaningful error.

Additional info:

Comment 1 Jeff Ortel 2011-12-03 00:00:54 UTC

build: 0.254.

Comment 2 Preethi Thomas 2011-12-15 15:05:54 UTC

verified

[root@preethi ~]# rpm -q pulp
pulp-0.0.254-7.fc15.noarch

2011-12-15 10:16:39,479 [ERROR][Actions] __call__() @ action.py:129 - Required section [client], not found in: /etc/pulp/consumer/consumer.conf
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/gofer/agent/action.py", line 127, in __call__
    self.target()
  File "/usr/lib64/gofer/plugins/pulpplugin.py", line 93, in heartbeat
    return self.send()
  File "/usr/lib64/gofer/plugins/pulpplugin.py", line 99, in send
    bundle = ConsumerBundle()
  File "/usr/lib/python2.7/site-packages/pulp/client/consumer/credentials.py", line 53, in __init__
    Bundle.__init__(self, self.path())
  File "/usr/lib/python2.7/site-packages/pulp/client/consumer/credentials.py", line 46, in path
    cfg = ConsumerConfig()
  File "/usr/lib/python2.7/site-packages/pulp/client/lib/config.py", line 126, in __init__
    self.validate()
  File "/usr/lib/python2.7/site-packages/pulp/client/consumer/config.py", line 103, in validate
    raise e
SectionNotFound: Required section [client], not found in: /etc/pulp/consumer/consumer.conf

Comment 3 Preethi Thomas 2012-02-24 20:17:16 UTC

Pulp v1.0 is released
Closed Current Release.

Comment 4 Preethi Thomas 2012-02-24 20:18:17 UTC

Pulp v1.0 is released.