Bug 759224

Summary: rpm -r does not complete
Product: [Fedora] Fedora Reporter: Jan Kratochvil <jan.kratochvil>
Component: bash-completionAssignee: Ville Skyttä <ville.skytta>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: jan.kratochvil, sheltren, ville.skytta
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: 1.99-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-08 12:21:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Fix. none

Description Jan Kratochvil 2011-12-01 17:53:46 UTC
Created attachment 539327 [details]
Fix.

bash-completion-1.3-6.fc16.noarch

Steps to Reproduce:
rpm -r /var/lib/mock/fedo<tab><tab>
... for some -i package.rpm

Actual results:
No completion.

Expected results:
Filename completion works.

Comment 1 Jan Kratochvil 2011-12-01 17:55:34 UTC
But maybe the fix is wrong.
rpm -i kernel-3.1.4-1.fc16.x86_6<tab><tab> works fine
(for a local file kernel-3.1.4-1.fc16.x86_64.rpm)
but even after the patch:
rpm -r /var/lib/mock/fedora-16-x86_64/root -i ker<tab><tab>
still does not work.

Comment 2 Ville Skyttä 2011-12-01 19:25:53 UTC
The fix is definitely correct, pushed upstream:
http://anonscm.debian.org/gitweb/?p=bash-completion/bash-completion.git;a=commitdiff;h=86d0395fc5efbeef9aad8cc27e84270f7c59faa1

Why the latter example still doesn't work is just because rpm is a pretty complex command to complete properly and there's lots of room for improvement.  Your example case would however work if given the other way around, i.e. "rpm -i ... -r ...".  As a rule of thumb, specifying the operation (-i, -U, -e etc) first, then additional options tends to result in best completion results at the moment.