Bug 759632

+++ This bug was initially created as a clone of Bug #759631 +++

Description of problem:
A machine that is not registered but has virt-who installed and running will spawn a stack trace every minute to stderr.

Unable to read certificate, system is not registered or you are not root
1
Traceback (most recent call last):
  File "/usr/share/virt-who/virt-who.py", line 126, in _send
  File "/usr/share/virt-who/virt-who.py", line 104, in checkConnections
  File "/usr/share/virt-who/virt-who.py", line 81, in initSM
SystemExit: 1
Unexcepted error occurs, trying to recover
Unable to read certificate, system is not registered or you are not root
1
Traceback (most recent call last):
  File "/usr/share/virt-who/virt-who.py", line 126, in _send
  File "/usr/share/virt-who/virt-who.py", line 104, in checkConnections
  File "/usr/share/virt-who/virt-who.py", line 81, in initSM
SystemExit: 1
Unable to recover, retry in 60 seconds.

Version-Release number of selected component (if applicable):
virt-who-0.4-1.el5

How reproducible:
Always

Actual results:
Stack trace

Expected results:
virt-who either dumps only to a log or silently ignores the error if not registered.  

Additional info:

Found using RHEV-H 5.8.  Simply boot the machine and wait, you'll get the above stack trace every minute.

Traced this to virt-who.py

    # Print debugging output to stderr too
    logger.addHandler(logging.StreamHandler())

this should probably either be removed or indented to only be active if running in debug mode:


diff --git a/virt-who.py b/virt-who.py
index 32be133..9c3a310 100644
--- a/virt-who.py
+++ b/virt-who.py
@@ -194,8 +194,8 @@ if __name__ == '__main__':
         # Enable debugging output to be writen in /var/log
         logger.setLevel(logging.DEBUG)

-    # Print debugging output to stderr too
-    logger.addHandler(logging.StreamHandler())
+        # Print debugging output to stderr too
+        logger.addHandler(logging.StreamHandler())

     env = os.getenv("VIRTWHO_BACKGROUND", "0").strip().lower()
     if env in ["1", "true"]: