Bug 759651

Summary: Bug found in the iface update for the new iface net config params
Product: Red Hat Enterprise Linux 5 Reporter: Eddie Wai <eddie.wai>
Component: iscsi-initiator-utilsAssignee: Mike Christie <mchristi>
Status: CLOSED ERRATA QA Contact: Bruno Goncalves <bgoncalv>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.8CC: coughlan, fge, mchristi
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-21 06:37:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 772956    
Attachments:
Description Flags
This patch fixes the iface update for the new iface net config params none

Description Eddie Wai 2011-12-02 22:31:35 UTC 
Description of problem:
Although the new iface additions of gateway/subnet/etc. are
now present in the iface file in rhel6.2 inbox open-iscsi util, however,
the particular parameters are not being passed to iscsiuio upon
connection request.

The problem looks to be related to the iface_rec inside the node_rec
only contains the previously defined fields and not the entire iface
fields.  Unfortunately for us, iscsiuio only gets the iface_rec from the
node_rec and not the iface_rec directly from the database...

Version-Release number of selected component (if applicable):
iscsi-initiator-utils-2.0.872-34

How reproducible:
Every time

Steps to Reproduce:
1.iscsiadm -m iface -I bnx2i-eth0 -n iface.mtu -v 1500 -o update
2.
3.
  
Actual results:
iscsiadm: Cannot modify iface.mtu. Invalid param name.
iscsiadm: Could not update iface bnx2i-eth0: invalid parameter


Expected results:
bnx2i-eth0 updated.

Additional info:
Comment 1 Eddie Wai 2011-12-02 22:41:08 UTC 
Created attachment 539817 [details]
This patch fixes the iface update for the new iface net config params

Augmented the idbm_recinfo_node routine to include the parsing of
the newly added iface net config params:
  bootproto
  subnet_mask
  gateway
  ipv6_autocfg
  linklocal_autocfg
  router_autocfg
  ipv6_linklocal
  ipv6_router
  state
  vlan_id
  vlan_priority
  vlan_state
  iface_num
  mtu
  port

This will also update the iface_rec instance inside the node_rec struct
for the iscsiuio iface_rec info passing for bnx2i offload.

Signed-off-by: Eddie Wai <eddie.wai>
Comment 3 Mike Christie 2012-01-04 06:01:16 UTC 
Fixed in iscsi-initiator-utils-6.2.0.872-13.el5. Get it in http://people.redhat.com/mchristi/iscsi/rhel5.8/iscsi-initiator-utils/
Comment 5 Bruno Goncalves 2012-01-12 10:03:56 UTC 
It is working on iscsi-initiator-utils-6.2.0.872-13.el5

iscsiadm -m iface -I bnx2i.00:10:18:88:e7:fd -n iface.mtu -v 1500 -o update
bnx2i.00:10:18:88:e7:fd updated.

iface.mtu = 1500
Comment 7 errata-xmlrpc 2012-02-21 06:37:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0263.html