Bug 759758

Summary:	Review Request: perl-Encode-HanExtra - Extra sets of Chinese encodings
Product:	[Fedora] Fedora	Reporter:	Xavier Bachelot <xavier>
Component:	Package Review	Assignee:	Ville Skyttä <ville.skytta>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review
Target Milestone:	---	Flags:	ville.skytta: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-22 19:28:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Xavier Bachelot 2011-12-03 16:14:38 UTC

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-HanExtra.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Encode-HanExtra-0.23-1.fc15.src.rpm
Description: 
Perl 5.7.3 and later ships with an adequate set of Chinese encodings,
including the commonly used CP950, CP936 (also known as GBK), Big5 (alias
for Big5-Eten), Big5-HKSCS, EUC-CN, HZ, and ISO-IR-165.
However, the numbers of Chinese encodings are staggering, and a complete
coverage will easily increase the size of perl distribution by several
megabytes; hence, this CPAN module tries to provide the rest of them.
If you are using Perl 5.8 or later, Encode::CN and Encode::TW will
automatically load the extra encodings for you, so there's no need to
explicitly write use Encode::HanExtra if you are using one of them already.


This module is needed for better test coverage in perl-MIME-Charset.

Comment 1 Ville Skyttä 2011-12-20 21:23:30 UTC

Same three "see rpmdevtools perl spec template" issues as in bug 759760 (zero-length *.bs, OPTIMIZE, and unnecessary dir ownership).

Comment 2 Xavier Bachelot 2011-12-21 00:11:55 UTC

Thanks Ville.
New version :
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-HanExtra.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-Encode-HanExtra-0.23-2.fc15.src.rpm

Comment 3 Ville Skyttä 2011-12-21 07:28:20 UTC

Um, now OPTIMIZE= is in the %setup line...

Comment 4 Xavier Bachelot 2011-12-21 09:25:35 UTC

oops, I shouldn't do this sort of stuff too late at night. Sorry about that.

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-HanExtra.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-Encode-HanExtra-0.23-3.fc15.src.rpm

Comment 5 Ville Skyttä 2011-12-21 19:47:36 UTC

Looks good now.

Comment 6 Xavier Bachelot 2011-12-21 20:19:26 UTC

Thanks for the review, Ville.

New Package SCM Request
=======================
Package Name: perl-Encode-HanExtra
Short Description: Extra sets of Chinese encodings
Owners: xavierb
Branches: f15 f16 el5 el6
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2011-12-21 20:21:12 UTC

Git done (by process-git-requests).

Comment 8 Xavier Bachelot 2011-12-22 19:28:05 UTC

Imported and build for Rawhide, F16, F15, EL6 and EL5.