Bug 759760

Summary:	Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Product:	[Fedora] Fedora	Reporter:	Xavier Bachelot <xavier>
Component:	Package Review	Assignee:	Ville Skyttä <ville.skytta>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review
Target Milestone:	---	Flags:	ville.skytta: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-22 19:28:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Xavier Bachelot 2011-12-03 16:14:41 UTC

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-JIS2K.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Encode-JIS2K-0.02-1.fc15.src.rpm
Description: 
This module implements encodings that covers JIS X 0213 charset (AKA JIS 2000,
hence the module name).


This module is needed for better test coverage in perl-MIME-Charset.

Comment 1 Ville Skyttä 2011-12-20 21:15:37 UTC

* Why include the ucm dir in docs?  I think it's essentially 1.2M of source code that's not useful when installed.

* Package is uninstallable after being built in Rawhide, it requires perl(Encode::JIS2K::2022JP3) which isn't provided by the package itself nor anything else in Fedora.  Just a hunch, maybe the package declaration at top of lib/Encode/JIS2K/2022JP3.pm should be Encode::JIS2K::2022JP3 instead of Encode::JIS7::2022JP3.

See the rpmdevtools perl spec template, following it would have prevented these issues:

* perl-Encode-JIS2K.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Encode/JIS2K/JIS2K.bs

* OPTIMIZE="$RPM_OPT_FLAGS" missing from Makefile.PL line.

* Unnecessary ownership of /usr/lib64/perl5/vendor_perl/auto dir, already owned by perl-libs.

Comment 2 Xavier Bachelot 2011-12-21 00:11:07 UTC

Thanks Ville.
I should have been more careful when cpanspec detected this module as noarch... Same for the other package.

Bad package declaration filed upstream at https://rt.cpan.org/Public/Bug/Display.html?id=73401

New version :
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-JIS2K.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-Encode-JIS2K-0.02-2.fc15.src.rpm

Comment 3 Ville Skyttä 2011-12-21 21:59:11 UTC

Looks good.

Comment 4 Xavier Bachelot 2011-12-21 22:02:46 UTC

Thanks for the review, Ville.

New Package SCM Request
=======================
Package Name: perl-Encode-JIS2K
Short Description: JIS X 0212 (aka JIS 2000) Encodings
Owners: xavierb
Branches: f15 f16 el5 el6
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2011-12-22 13:21:33 UTC

Git done (by process-git-requests).

Comment 6 Xavier Bachelot 2011-12-22 19:28:52 UTC

Imported and built for Rawhide, F16, F15, EL6 and EL5.