Bug 759941
| Summary: | Review Request: spatialite-gui - GUI to manage Spatialite databases | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Volker Fröhlich <volker27> |
| Component: | Package Review | Assignee: | Mattia Verga <mattia.verga> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mattia.verga, notting, package-review |
| Target Milestone: | --- | Flags: | mattia.verga:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | spatialite-gui-1.4.0-3.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-19 01:32:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Volker Fröhlich
2011-12-05 00:15:04 UTC
Are the ldconfig calls in %post and %postun really needed? This package seems to not add any library. Thanks, they're rubbish. Spec URL: http://www.geofrogger.net/review/spatialite-gui.spec SRPM URL: http://www.geofrogger.net/review/spatialite-gui-1.4.0-2.fc15.src.rpm I'm going to review this - rpmlint checks return: spatialite-gui.x86_64: W: no-manual-page-for-binary spatialite_gui 3 packages and 1 specfiles checked; 0 errors, 1 warnings. Warning can be ignored: OK - naming guidelines and .spec file name: OK - packaging guidelines: OK - license: OK (GPLv3), in %doc - spec file legible, in am. english: OK - source matches upstream: OK - package compiles on (i686/x86_64): OK + Build Requires / Requires: NOTE 1 - no locales - no libraries - not relocatable - no directories created - no duplicate files - file permissions: OK - macros: OK - code/content: OK - no need for -docs - nothing in %doc affects runtime - no headers / no need for -devel - .desktop file: OK - ownership: OK - filenames: OK NOTES: -------------- 1: The required packages are automatically added by rpm, however I'm thinking about the opportunity to specify a 'require: libspatialite', since this package has no functionality without it. What do you think? That is not a blocker, so I mark this as APPROVED. Thank you for the review! Why do you want to have an explicit Requires? The binary is linked to libspatialite thus it effectively is required in order to install spatialite-gui. It also should not be done, as far as I know: http://fedoraproject.org/wiki/PackagingGuidelines#Requires (In reply to comment #5) > Thank you for the review! > > Why do you want to have an explicit Requires? The binary is linked to > libspatialite thus it effectively is required in order to install > spatialite-gui. > > It also should not be done, as far as I know: > > http://fedoraproject.org/wiki/PackagingGuidelines#Requires Yes, it's right like Packaging Guidelines say (so I approved it). In my opinion I would expect a [foo]-gui package depends on a [foo] package, since there's no 'spatialite' package in repos I think this is a bit weird to have 'spatialite-gui'. But this is only a personal opinion! New Package SCM Request ======================= Package Name: spatialite-gui Short Description: GUI to manage Spatialite databases Owners: volter Branches: f15 f16 el6 Git done (by process-git-requests). spatialite-gui-1.4.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spatialite-gui-1.4.0-3.fc16 spatialite-gui-1.4.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/spatialite-gui-1.4.0-3.fc15 spatialite-gui-1.4.0-3.fc16 has been pushed to the Fedora 16 testing repository. spatialite-gui-1.4.0-3.fc16 has been pushed to the Fedora 16 stable repository. spatialite-gui-1.4.0-3.fc15 has been pushed to the Fedora 15 stable repository. |