Bug 760153

Summary:	Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb
Product:	[Fedora] Fedora	Reporter:	Thomas Moschny <thomas.moschny>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, tcallawa
Target Milestone:	---	Flags:	tcallawa: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	xcb-util-wm-0.3.8-2.fc17	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-14 04:30:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Thomas Moschny 2011-12-05 14:42:38 UTC

Spec URL: http://thm.fedorapeople.org/xcb-util-wm/xcb-util-wm.spec
SRPM URL: http://thm.fedorapeople.org/xcb-util-wm/xcb-util-wm-0.3.8-1.fc16.src.rpm
Description:
XCB util-wm module provides the following libraries:

  - ewmh: Both client and window-manager helpers for EWMH.
  - icccm: Both client and window-manager helpers for ICCCM.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3563676

Comment 1 Tom "spot" Callaway 2012-04-02 20:02:23 UTC

Review
=======

There are some minor cleanups you can make like:

* drop rm -rf %{buildroot} from %install
* drop default defattr lines
* drop BuildRoot line
* Use %{name}%{?_isa} instead of just %{name} in explicit Requires:
* Fix the devel description (s/xcb-utilwm/xcb-util-wm).

But all of those are minor. Just consider making those changes before committing.

Good:

- rpmlint checks return:
xcb-util-wm.src: W: spelling-error Summary(en_US) libxcb -> Libby
xcb-util-wm.src: W: spelling-error %description -l en_US ewmh -> whew
xcb-util-wm.src: W: spelling-error %description -l en_US icccm -> ICC
xcb-util-wm.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby
xcb-util-wm.x86_64: W: spelling-error %description -l en_US ewmh -> whew
xcb-util-wm.x86_64: W: spelling-error %description -l en_US icccm -> ICC
xcb-util-wm-devel.x86_64: W: spelling-error Summary(en_US) vm -> cm, v, m
xcb-util-wm-devel.x86_64: W: spelling-error %description -l en_US utilwm -> utility

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

APPROVED.

Comment 2 Thomas Moschny 2012-04-03 07:14:04 UTC

Thanks for the review spot!

New Package SCM Request
=======================
Package Name: xcb-util-wm
Short Description: Client and window-manager helper library on top of libxcb
Owners: thm
Branches: f17
InitialCC:

Comment 3 Gwyn Ciesla 2012-04-03 13:55:00 UTC

Git done (by process-git-requests).

Comment 4 Fedora Update System 2012-04-05 14:29:47 UTC

xcb-util-wm-0.3.8-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/xcb-util-wm-0.3.8-2.fc17

Comment 5 Fedora Update System 2012-04-06 23:23:52 UTC

xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 6 Fedora Update System 2012-04-14 04:30:08 UTC

xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 stable repository.