| Summary: | Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Moschny <thomas.moschny> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | xcb-util-image-0.3.8-2.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-04-14 04:29:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Thomas Moschny
2011-12-05 14:42:42 UTC
Spec URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image.spec SRPM URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image-0.3.8-2.fc18.src.rpm Spec file updates: - Drop BR on pkgconfig - Drop BuildRoot tag - Drop defattr lines - Use %{_isa} in explicit dependency - Remove chrpath, seems unnecessary Review ======= - rpmlint checks return: xcb-util-image.src: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-image.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby 4 packages and 0 specfiles checked; 0 errors, 2 warnings. All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED. Thanks for the review, spot! New Package SCM Request ======================= Package Name: xcb-util-image Short Description: Port of Xlib's XImage and XShmImage functions on top of libxcb Owners: thm Branches: f17 InitialCC: Git done (by process-git-requests). xcb-util-image-0.3.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xcb-util-image-0.3.8-2.fc17 xcb-util-image-0.3.8-2.fc17 has been pushed to the Fedora 17 testing repository. xcb-util-image-0.3.8-2.fc17 has been pushed to the Fedora 17 stable repository. |