Bug 760193

Summary: radtest PPPhint option is not parsed properly
Product: Red Hat Enterprise Linux 5 Reporter: Aleš Mareček <amarecek>
Component: freeradius2Assignee: John Dennis <jdennis>
Status: CLOSED ERRATA QA Contact: Aleš Mareček <amarecek>
Severity: high Docs Contact:
Priority: high    
Version: 5.8CC: ckannan, dpal, ksrot
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: freeradius2-2.1.12-3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 787116 (view as bug list) Environment:
Last Closed: 2012-02-21 05:36:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch none

Description Aleš Mareček 2011-12-05 15:56:20 UTC
Description of problem:
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# man radtest | grep -A3 ppphint
       ppphint
              If  you put an integer > 0 here, radtest (or actually radclient)
              will add the attribute Framed-Protocol  =  PPP  to  the  request
              packet.
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# /usr/bin/radtest --help
Usage: radtest [OPTIONS] user passwd radius-server[:port] nas-port-number secret [ppphint] [nasname]
        -d RADIUS_DIR       Set radius directory
        -t <type>           Set authentication method
                            type can be pap, chap, mschap, or eap-md5
        -x                  Enable debug output
        -4                  Use IPv4 for the NAS address (default)
        -6                  Use IPv6 for the NAS address
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# /usr/bin/radtest -x -4 testuser RedHat localhost:1812 1812 RedHat 0 localhost
Sending Access-Request of id 149 to 127.0.0.1 port 1812
	User-Name = "testuser"
	User-Password = "RedHat"
	NAS-IP-Address = 127.0.0.1
	NAS-Port = 1812
	Message-Authenticator = 0x00000000000000000000000000000000
	Framed-Protocol = PPP
Sending Access-Request of id 149 to 127.0.0.1 port 1812
	User-Name = "testuser"
	User-Password = "RedHat"
	NAS-IP-Address = 127.0.0.1
	NAS-Port = 1812
	Message-Authenticator = 0x00000000000000000000000000000000
	Framed-Protocol = PPP
Sending Access-Request of id 149 to 127.0.0.1 port 1812
	User-Name = "testuser"
	User-Password = "RedHat"
	NAS-IP-Address = 127.0.0.1
	NAS-Port = 1812
	Message-Authenticator = 0x00000000000000000000000000000000
	Framed-Protocol = PPP
radclient: no response from server for ID 149 socket 3
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# grep '$6' /usr/bin/radtest
	if [ "$6" ]


Version-Release number of selected component (if applicable):
freeradius2-2.1.12-2.el5
freeradius2-utils-2.1.12-2.el5

How reproducible:
Always

Steps to Reproduce:
1. run command: /usr/bin/radtest -x -4 testuser RedHat localhost:1812 1812 RedHat 0 localhost | grep -q "PPP" && echo FAIL || echo PASS
and wait a few seconds
  
Actual results:
FAIL

Expected results:
PASS

Additional info:

Comment 1 Aleš Mareček 2011-12-05 15:58:22 UTC
Created attachment 540999 [details]
Patch

Comment 7 John Dennis 2012-01-06 13:34:25 UTC
FWIW I tested the proposed patch, it did not work. The problem is you cannot quote the right hand side of a regular expression operator. The shell will not recognize the regexp as a regexp if it's quoted. Other than that it was well done.

After making that tweak all my testing was successful.

Comment 9 errata-xmlrpc 2012-02-21 05:36:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0196.html