| Summary: | API allows promotion of empty products, breaks repo addition in UI | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Jeff Weiss <jweiss> |
| Component: | Infrastructure | Assignee: | Lukas Zapletal <lzap> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Katello QA List <katello-qa-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0.0 | CC: | bkearney, dajohnso, sghai |
| Target Milestone: | Unspecified | Keywords: | Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-22 18:11:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 747354 | ||
|
Description
Jeff Weiss
2011-12-06 19:55:43 UTC
Right now it promotes. kk changeset promote --name empty --environment testing Changeset [ empty ] promoted Taking. 765888 - Error during promotion I verified this on latest katello build: katello-glue-pulp-0.1.155-1.el6.noarch katello-configure-0.1.48-1.el6.noarch katello-trusted-ssl-cert-1.0-1.noarch katello-cli-common-0.1.31-1.el6.noarch katello-glue-foreman-0.1.155-1.el6.noarch katello-common-0.1.155-1.el6.noarch katello-httpd-ssl-key-pair-1.0-1.noarch katello-0.1.155-1.el6.noarch katello-qpid-broker-key-pair-1.0-1.noarch katello-repos-0.1.4-1.el6.noarch katello-cli-0.1.31-1.el6.noarch katello-glue-candlepin-0.1.155-1.el6.noarch katello-all-0.1.155-1.el6.noarch katello-certs-tools-1.0.1-1.el6.noarch I can still promote a empty product ( product with no repos ) I created a provider 'rhel' and created a product 'myproduct' and promoted it to 'test' env and it was promoted successfully. However a proper error should be raised "Product with no repo can not be promoted" ---- katello> product create --name myproduct --org ACME_Corporation --provider rhel Successfully created product [ myproduct ] katello> changeset create --org ACME_Corporation --environment test --name empty Successfully created changeset [ empty ] for environment [ test ] katello> changeset update --org ACME_Corporation --environment test --name empty --add_product myproduct Successfully updated changeset [ empty ] katello> changeset promote --name empty --environment test --org ACME_Corporation Changeset [ empty ] promoted --- How about: [lzap@lzapx src]$ kk changeset update --name empty --environment env --add_product empty_product Product 'empty_product' hasn't any repositories It is not possible to add empty product now. 4a7649b 760703 - promotion of empty products now not possible Verified with following katello build: katello-0.1.192-1.el6.noarch Now while updating a changeset with empty product will raise a message as below: Product 'myproduct' hasn't any repositories ----- katello> provider create --name rhel --org ACME_Corporation Successfully created provider [ rhel ] katello> product create --name myproduct --org ACME_Corporation --provider rhel Successfully created product [ myproduct ] katello> changeset create --org ACME_Corporation --environment test --name empty Successfully created changeset [ empty ] for environment [ test ] katello> changeset update --org ACME_Corporation --environment test --name empty --add_product myproduct Product 'myproduct' hasn't any repositories ---- |