Bug 76071

Summary: getkey seg-faults with no wait message, also needs to be able to ignore control characters
Product: [Retired] Red Hat Linux Reporter: Benjamin Delfin <ben>
Component: initscriptsAssignee: Bill Nottingham <notting>
Status: CLOSED RAWHIDE QA Contact: Brock Organ <borgan>
Severity: low Docs Contact:
Priority: medium    
Version: 7.3CC: rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2003-01-14 05:07:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
source code fix, and enhancements (such as --help message)
none
Makefile for changed getkey
none
Improved source code file -- removed memory leak, restored allowing no keys to be specified, so that any key being hit can be captured, as was the case before. none

Description Benjamin Delfin 2002-10-16 15:43:42 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; Q312461)

Description of problem:
When getkey is invoked with a wait period but no wait message, it core dumps.  
Also, there should be an option to allow getkey to ignore Control-C and Control-
D characters.  It's inability to avoid these characters can cause problems when 
dealing with the Linux Progress Patch.  When we used getkey to check for a 
keypress in order to reset a machine's environment and reboot, it would always 
do so when using the Linux Progress Patch, whether or not the key was actually 
pressed.  Finally, a NULL character passed to getkey will be interpreted as a 
successful match against it's list of characters.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Type "getkey -c 5 d" and wait.
	

Actual Results:  You get garbage characters, repeated 5 times, followed by a 
segmentation fault.

Expected Results:  It should have waited 5 seconds for the d key, then ended 
gracefully.

Additional info:
Comment 1 Benjamin Delfin 2002-10-16 15:45:39 UTC 
Created attachment 80666 [details]
source code fix, and enhancements (such as --help message)
Comment 2 Benjamin Delfin 2002-10-16 15:46:24 UTC 
Created attachment 80667 [details]
Makefile for changed getkey
Comment 3 Benjamin Delfin 2002-10-16 16:07:47 UTC 
Also added popt library usage, to provide long aliases for options and help 
messages.  Made getkey fail if no list of characters is provided -- was that 
last change a good idea?  Maybe that last bit should be removed?
Comment 4 Benjamin Delfin 2002-10-16 18:13:03 UTC 
Created attachment 80704 [details]
Improved source code file -- removed memory leak, restored allowing no keys to be specified, so that any key being hit can be captured, as was the case before.
Comment 5 Bill Nottingham 2002-11-12 05:55:44 UTC 
*** Bug 76070 has been marked as a duplicate of this bug. ***
Comment 6 Bill Nottingham 2003-01-14 05:07:25 UTC 
Added in 7.03-1, thanks!