Bug 760839
| Summary: | build without tcl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bill Nottingham <notting> | ||||
| Component: | usb_modeswitch | Assignee: | romal <linux> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 16 | CC: | dcbw, huzaifas, linux, rvokal | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-05-22 02:23:00 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 799144 | ||||||
| Attachments: |
|
||||||
Ping? Updated patch against 1.2.2 is:
diff --git a/usb_modeswitch.spec b/usb_modeswitch.spec
index ae7a4a5..469d0ce 100644
--- a/usb_modeswitch.spec
+++ b/usb_modeswitch.spec
@@ -37,7 +37,7 @@ touch -r device_reference.txt device_reference.txt.new && \
mv device_reference.txt.new device_reference.txt
%build
-CFLAGS="$RPM_OPT_FLAGS" make %{?_smp_mflags}
+CFLAGS="$RPM_OPT_FLAGS" make %{?_smp_mflags} static
%install
@@ -48,7 +48,7 @@ mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}
install -p -m 755 usb_modeswitch $RPM_BUILD_ROOT%{_sbindir}/
-install -p -m 755 usb_modeswitch.tcl $RPM_BUILD_ROOT%{_sbindir}/usb_modeswitch_dispatcher
+install -p -m 755 usb_modeswitch_dispatcher $RPM_BUILD_ROOT%{_sbindir}/
install -p -m 644 usb_modeswitch.conf $RPM_BUILD_ROOT%{_sysconfdir}/
gzip -9c usb_modeswitch.1 > usb_modeswitch.1.gz && install -m 644 usb_modeswitch.1.gz $RPM_BUILD_ROOT%{_datadir}/man/man1
install -p -m 755 usb_modeswitch.sh $RPM_BUILD_ROOT/lib/udev/usb_modeswitch
and that works for 6 WWAN dongles I pulled out of my box.
(ZTE MF627, Huawei UMG1831, Alcatel/TCT OneTouch X200, Samsung SGH-Z810, Huawei E1552, Zoom 4597) usb_modeswitch-data-20120120-1.fc16,usb_modeswitch-1.2.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/usb_modeswitch-data-20120120-1.fc16,usb_modeswitch-1.2.3-1.fc16 usb_modeswitch-data-20120120-1.fc17,usb_modeswitch-1.2.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/usb_modeswitch-data-20120120-1.fc17,usb_modeswitch-1.2.3-1.fc17 Package usb_modeswitch-data-20120120-1.fc16, usb_modeswitch-1.2.3-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing usb_modeswitch-data-20120120-1.fc16 usb_modeswitch-1.2.3-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-6617/usb_modeswitch-data-20120120-1.fc16,usb_modeswitch-1.2.3-1.fc16 then log in and leave karma (feedback). usb_modeswitch-data-20120120-1.fc16, usb_modeswitch-1.2.3-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. usb_modeswitch-data-20120120-1.fc17, usb_modeswitch-1.2.3-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 541721 [details] spec diff Description of problem: Increases size of usb_modeswitch package from 168k to 324k, but allows us to drop a 4.4MB tcl package that is unlikely to be used for anything else on a default install/live image. Version-Release number of selected component (if applicable): usb_modeswitch-1.2.0 Additional Information: 'static' just means make a binary out of the tcl script; it's still dynamically linked.