Bug 760991

Created attachment 541976 [details]
File: smolt_data

Submitted bug and suggested fix/patch at synce...

https://sourceforge.net/tracker/?func=detail&aid=3485372&group_id=30550&atid=399601

I've made some other changes there was well and suggested making a new release containing those fixes.

In the meantime, here's a patch.  Note that /etc/org.synce.dccm.conf has a critical permission added thus you'll want to replace it, but it's marked as noreplace in the rpm.


svn diff -r4037:4041 connector/
Index: connector/scripts/synceconnector.py.in
===================================================================
--- connector/scripts/synceconnector.py.in	(revision 4037)
+++ connector/scripts/synceconnector.py.in	(revision 4041)
@@ -345,8 +345,8 @@
 
     try:
         dccm_manager.DeviceConnected(device_path, device_ip, local_ip, rndis)
-    except:
-        logger.critical("failed to signal device connect to dccm device manager %s: %s" % (our_udi, e))
+    except Exception,e:
+        logger.critical("failed to signal device connect to dccm device manager %s: %s" % (device_path, e))
         return False
 
     return True
Index: connector/src/synce-device-manager.c
===================================================================
--- connector/src/synce-device-manager.c	(revision 4037)
+++ connector/src/synce-device-manager.c	(revision 4041)
@@ -219,8 +219,12 @@
 
   g_debug("%s: listening for device %s", G_STRFUNC, deventry->device_path);
 
-  if (deventry->rndis)
+  if (deventry->rndis) {
+  g_debug("%s: triggering connection", G_STRFUNC);
     synce_trigger_connection(deventry->device_ip);
+  } else {
+  g_debug("%s: NOT triggering connection", G_STRFUNC);
+}
 
   return TRUE;
 }
@@ -331,24 +335,41 @@
   *ret = g_ptr_array_new ();
 
   GSList *device_entry_iter = priv->devices;
-  while (device_entry_iter != NULL) {
 
+  for (; device_entry_iter; device_entry_iter = g_slist_next(device_entry_iter)) {
+
+  DeviceEntry *deventry = device_entry_iter->data;
+
+  if (!deventry) {
+    g_critical("%s: DeviceEntry was null", G_STRFUNC);
+    continue;
+  }
+
+  g_debug("%s: deventry->device_path = %s", G_STRFUNC, deventry->device_path);
+  g_debug("%s: deventry->device_ip = %s", G_STRFUNC, deventry->device_ip);
+  g_debug("%s: deventry->local_ip = %s", G_STRFUNC, deventry->local_ip);
+  g_debug("%s: deventry->rndis = %s", G_STRFUNC, (deventry->rndis ? "true" : "false"));
+  g_debug("%s: deventry->iface_pending = %s", G_STRFUNC, (deventry->iface_pending ? "true" : "false"));
+
     gchar *obj_path;
     SynceDevice *device = ((DeviceEntry*)device_entry_iter->data)->device;
-    if (device == NULL)
+    if (device == NULL) {
+      g_debug("%s: device was null", G_STRFUNC);
       /* interface is not yet ready */
       continue;
+    }
 
     g_object_get (device, "object-path", &obj_path, NULL);
-    if (obj_path == NULL)
+    if (obj_path == NULL) {
+      g_debug("%s: object path was null", G_STRFUNC);
       /* device is not yet ready */
       continue;
+    }
 
     g_debug("%s: found device %s with object path %s", G_STRFUNC, ((DeviceEntry*)device_entry_iter->data)->device_path, obj_path);
 
     g_ptr_array_add (*ret, obj_path);
 
-    device_entry_iter = g_slist_next(device_entry_iter);
   }
 
   return TRUE;

Property changes on: connector/src/synce-device-manager.c
___________________________________________________________________
Added: svn:mergeinfo
   Merged /trunk/core/dccm/synce-device-manager.c:r4039

Index: connector/etc/org.synce.dccm.conf
===================================================================
--- connector/etc/org.synce.dccm.conf	(revision 4037)
+++ connector/etc/org.synce.dccm.conf	(revision 4041)
@@ -13,6 +13,7 @@
 
   <!-- Allow anyone to invoke methods on the Device and DeviceManager interfaces -->
   <policy context="default">
+    <allow send_type="method_call"/>
     <allow send_destination="org.synce.dccm"
 	   send_interface="org.synce.dccm.Device"/>

Created attachment 560123 [details]
fix patch

Made a patch against the 0.15.2 source tar distribution.

Created attachment 560307 [details]
git patch

Patch against the fedora git repo synce-connector.git.
- Added source patch
- Updated spec file

Tested locally.

Patch from attachment 560123 [details] seems to works for me.

I do have to manually replace the /etc/dbus-1/system.d/org.synce.dccm.conf file as Robert mentioned, and I have to disable the firewall (at least until I figure out how best to configure the firewall), but after that it works.

Thanks Robert!

Is this going to hit F17 too?

Thanks
Pablo

This message is a reminder that Fedora 16 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 16. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '16'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 16's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 16 is end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" and open it against that version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Fedora 16 changed to end-of-life (EOL) status on 2013-02-12. Fedora 16 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.