Bug 761565

Summary: Missing deps on netpbm-progs and icoutils
Product: [Fedora] Fedora Reporter: Matthew Booth <mbooth>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: mbooth, rjones, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-30 13:08:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matthew Booth 2011-12-08 15:51:46 UTC 
Description of problem:
Running virt-inspector against one of my Windows guests output the following to stderr:

# virt-inspector windevel.img > /dev/null
sh: pamcut: command not found
sh: wrestool: command not found
sh: pnmtopng: command not found
sh: bmptopnm: command not found

Installing netpbm-progs and icoutils resolved these dependencies.

Version-Release number of selected component (if applicable):
libguestfs-1.14.6-1.fc16.x86_64
Comment 1 Richard W.M. Jones 2011-12-08 15:58:50 UTC 
icoutils requires Perl ...

We'll have to devise a way to make these optional, since
they are only required for icons.
Comment 2 Richard W.M. Jones 2012-11-30 13:08:36 UTC 
This is fixed.  First of all the dependencies have been
added to the base libguestfs package:

# For core inspection API.
Requires:      libdb-utils
Requires:      netpbm-progs
Requires:      icoutils

Secondly the code was changed so that even if these programs
are not present, we get degraded functionality but no huge
ugly error messages.  At build time:

commit 2c9c0525ebda105f37e6a6eea2307db4cb2f0a73
Author: Richard W.M. Jones <rjones>
Date:   Wed Mar 7 15:07:37 2012 +0000

    build: Make netpbm and icoutils into proper optional dependencies.
    
    Netpbm and icoutils (wrestool) have always been dependencies.  Since
    they are not always present, make these into optional dependencies
    (which they were, sort of, before).
    
    Also document these dependencies in the README file.

and at run time the use of the new command "mini-library"
ensures that error output goes into the debug log (and not
to stderr) by default:

commit 019b840e4758ccd254925181f6fbaf3192c7bde1
Author: Richard W.M. Jones <rjones>
Date:   Thu Oct 18 10:55:42 2012 +0100

    inspect: Change icon code to use command mini-lib instead of system(3).