| Summary: | Error message incorrect when fuse_mount() fails | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Vijay Bellur <vijay> |
| Component: | fuse | Assignee: | Anand Avati <aavati> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 2.0.6 | CC: | chrisw, csaba, gluster-bugs, lakshmipathi |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | RTNR | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Vijay Bellur
2009-08-17 04:16:03 UTC
The problem is that "Appropriate error needs to be printed in the debug" is not really possible to fulfil. We don't know anything here about the reasons of the failure. fuse_mount() doesn't set an errno (and we see "Success" there because that's what strerror(0) gives with glibc).
Best that can be done here is to separate error messages further, like
if (errno)
gf_log (... strerror (errno) ...);
else
gf_log (... lame excuse ...);
-- if it is worth for the effort at all.
(In reply to comment #1) > The problem is that "Appropriate error needs to be printed in the debug" is not > really possible to fulfil. We don't know anything here about the reasons of the > failure. fuse_mount() doesn't set an errno (and we see "Success" there because > that's what strerror(0) gives with glibc). > > Best that can be done here is to separate error messages further, like > > if (errno) > gf_log (... strerror (errno) ...); > else > gf_log (... lame excuse ...); > > -- if it is worth for the effort at all. I think it is worth the effort since we are avoiding an oxymoron like "failed with error Success" and hence prevent a screenshot of glusterfs in DailyWTF :-) PATCH: http://patches.gluster.com/patch/1057 in release-2.0 (fuse: don't say "Success" when mount fails) |