Bug 76234
Summary: | check-files fails if $RPM_BUILD_ROOT contains // | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] Red Hat Linux | Reporter: | David Juran <djuran> | ||||
Component: | rpm-build | Assignee: | Jeff Johnson <jbj> | ||||
Status: | CLOSED NOTABUG | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 8.0 | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2002-11-02 16:58:40 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
David Juran
2002-10-18 15:13:56 UTC
Created attachment 80944 [details]
This patch will solve the problem
The patch is OK (but perl, ick :-) However, the real problem is that RPM_BUILD_ROOT should never have had the double // in the first place. How are you setting RPM_BUILD_ROOT? Manually, or just using what rpm provides? If rpm, what version, and do you have redhat-rpm-config installed (or otherwise configuring rpm)? I agree the original problem was that RPM_BUILD_ROOT contained doubble slashes, however this little patch will make the script more robust. (And I guess it could be make in sed as well (-: I stumbeled upon the error while rebuilding a 3:rd party rpm, http://ac2i.tzo.com/dctc/dctc-0.83.6-1.src.rpm I think it was. I never did find out why I got that extra '/' in that variable, (can't say I looked that hard for it though.) But no, I don not set it manually nor is it set in the spec-file either as far as I can see. And no, I don't have redhat-rpm/config installed. I have rpm-4.1-1.06 Again, the real problem (and fix) is to sanitize the RPM_BUILD_ROOT path to remove the double '//', not to deal with the symptom by hacking the check-files script. Ther are serious problems with non-canonical paths like BuildRoot: /../../../../some_path that cannot be fixed or worked around in scripts. Yes "//" is innocuous, the general canonicalization problem remains. FWIW, the check-files script will be replaced by an rpmbuild internal fts(3) walk in rpm-4.2. I don't see a double '//' when rebuilding the package. That means that your machine is configured with either a trailing slash on the macro %_tmpdir and/or a configured %buildroot. See the output of rpm --showrc to figger what's up. |