Bug 762480 (GLUSTER-748)

Summary: Issues reported by cppcheck
Product: [Community] GlusterFS Reporter: Vijay Bellur <vijay>
Component: coreAssignee: Anand Avati <aavati>
Status: CLOSED DUPLICATE QA Contact:
Severity: medium Docs Contact:
Priority: low    
Version: 3.0.3CC: chrisw, csaba, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Vijay Bellur 2010-03-22 07:11:29 UTC
Mail from Patrick Mathai [pmatthaei at debian dot org] on gluster-devel:

Hello,

I have checked glusterfs 3.0.3 with cppcheck and it gave me the following errors (which must not be true at all):

[./libglusterfs/src/dict.c:179]: (error) Memory leak: newdata
[./libglusterfs/src/dict.c:251]: (error) Memory leak: pair
[./libglusterfs/src/fd.c:464]: (error) Possible null pointer dereference: fd - otherwise it is redundant to check if fd is null at line 466
[./libglusterfs/src/y.tab.c:1743]: (error) Memory leak: node
[./libglusterfs/src/y.tab.c:2067]: (error) Memory leak: cmd
[./xlators/protocol/client/src/client-protocol.c:3434]: (error) Possible null pointer dereference: iobuf - otherwise it is redundant to check if iobuf is null at line 3505
[./xlators/protocol/server/src/server-protocol.c:324]: (error) Possible null pointer dereference: state - otherwise it is redundant to check if state is null at line 344


Could you please have a look at them?

Comment 1 Csaba Henk 2010-03-22 20:34:05 UTC

*** This bug has been marked as a duplicate of bug 420 ***