Bug 762561 (GLUSTER-829)

Summary: SETATTR stack leak?
Product: [Community] GlusterFS Reporter: Krishna Srinivas <krishna>
Component: fuseAssignee: Csaba Henk <csaba>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: amarts, anush, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Krishna Srinivas 2010-04-18 23:26:28 UTC
glusterdump had:
[global.callpool]
global.callpool=0x10ef1310
global.callpool.cnt=352

all the 352 calls were SETATTR

looking at the code, when truncate is combined with any other operation in the same SETATTR call, it looks like there is a stack leak.

fuse_setattr_cbk():


                if (state->truncate_needed) {
                        fuse_do_truncate (state, state->size);
                } else {

when this happens the stack used for the other operation in SETATTR is not getting destroyed.

This was observed in a customer environment.

This does not affect the working of application making the calls though.

Comment 1 Anand Avati 2010-04-23 10:32:41 UTC
PATCH: http://patches.gluster.com/patch/3164 in master (mount/fuse: Destroy STACK when truncate and other op are part of same SETATTR)

Comment 2 Anand Avati 2010-04-23 10:33:13 UTC
PATCH: http://patches.gluster.com/patch/3165 in release-3.0 (mount/fuse: Destroy STACK when truncate and other op are part of same SETATTR)