Bug 762565 (GLUSTER-833)

Summary:	WB: rename enable-trickling-writes to aggregate
Product:	[Community] GlusterFS	Reporter:	Krishna Srinivas <krishna>
Component:	read-ahead	Assignee:	Raghavendra G <raghavendra>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	amarts, anush, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	RTNR	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Raghavendra G 2010-04-20 01:31:03 UTC

"enable-trickling-writes on" is not exactly equal to "aggregate off", since there can be aggregation of writes from application from the time last sync was done till a reply for this sync is received. 

The main intention of having enable-trickling-writes was to write the data to network whenever write-behind perceives the network to be free. Aggregation is the side-effect of this intention. Hence a different name was chosen for that option.

Comment 1 Krishna Srinivas 2010-04-20 03:11:54 UTC

in write-behind rename option enable-trickling-writes to aggregate.
"enable-trickling-writes on" should be "aggregate off"
"enable-trickling-writes off" should be "aggregate on"

enable-tricking-writes is related to aggregation of write chunks right?

AB's suggestion, which is valid.

Comment 2 Amar Tumballi 2010-04-20 08:38:51 UTC

can we think of better name than 'aggregate' ?