| Summary: | Crash with SEGV in libglusterfs on 32 bit, big endian platform | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | tlisiecki | ||||
| Component: | porting | Assignee: | Amar Tumballi <amarts> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 3.0.4 | CC: | gluster-bugs, vraman | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | ppc | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
(In reply to comment #1) > Created an attachment (id=231) [details] > proposed patch > > Please consider this patch. > It sloves porting problem on 32 bits big endian platforms. This patch is valid. Can you please submit it through 'git diff' across our latest codebase (master,release-3.0 branch), and mail it to glusterfs.com ?? that way our patchwork integration sees it. (patches.gluster.com) -Amar Please look on struct (from inode.h) and consider what happends when we are trying to read union fields alternatively (like in inode.c line: 285, 1370):
struct _inode_ctx {
union {
uint64_t key; // <--- alwyas 64 bits length
xlator_t *xl_key; // <--- 64 or 32 bits length
};
union {
uint64_t value1;
void *ptr1;
};
union {
uint64_t value2;
void *ptr2;
};
};
On 64 bits platforms all works fine while the length of union's filed are equal.
On 32 bits little endian (PC) platforms it still works.
On 32 bits big endian platforms it crashes.
PATCH: http://patches.gluster.com/patch/3544 in master (Handle a crash in inode.c on 32 bit, big endian platform) Applied the patch, should fix the issues.. |
Created attachment 231 [details] Dutch keyboard definition for loadkeys Please consider this patch. It sloves porting problem on 32 bits big endian platforms.