Bug 762765 (GLUSTER-1033)

Summary: io-threads doesn't log its options
Product: [Community] GlusterFS Reporter: Anush Shetty <anush>
Component: io-threadsAssignee: Shehjar Tikoo <shehjart>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: gluster-bugs, kbudiger, tejas, vijay
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Anush Shetty 2010-06-28 07:13:47 UTC
io-threads doesn't log its options properly. When the values set are invalid, it is logged though.


       if (dict_get (options, "thread-count")) {
                thread_count = data_to_int32 (dict_get (options,
                                                        "thread-count"));
                if (thread_count < IOT_MIN_THREADS)
                        thread_count = IOT_MIN_THREADS;

                if (thread_count > IOT_MAX_THREADS)
                        thread_count = IOT_MAX_THREADS;
        }
        conf->max_count = thread_count;

        if (dict_get (options, "idle-time")) {
                idle_time = data_to_int32 (dict_get (options,
                                                     "idle-time"));
                if (idle_time < 0)
                        idle_time = 1;
        }
        conf->idle_time = idle_time;

Comment 1 Anand Avati 2010-08-12 04:45:56 UTC
PATCH: http://patches.gluster.com/patch/4082 in master (log added in case of invalid options provided for the io-threads volume)