Bug 763118 (GLUSTER-1386)

Summary: gnfs nfs3_mknod must handle invalid device type
Product: [Community] GlusterFS Reporter: Sachidananda Urs <sac>
Component: nfsAssignee: Shehjar Tikoo <shehjart>
Status: CLOSED NOTABUG QA Contact:
Severity: low Docs Contact:
Priority: high    
Version: 3.1-alphaCC: gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: RTNR Mount Type: nfs
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Sachidananda Urs 2010-08-17 06:08:55 EDT
Dead store  Dead assignment  xlators/nfs/server/src/nfs3.c  2860  1

Refer below url for line number and function name:
http://dev.gluster.com/~raghavendrabhat/2010-07-14-1/report-TWZ0sf.html#EndPath

Shehjar wrote:

@@ -2857,7 +2855,7 @@ nfs3_mknod (rpcsvc_request_t *req, struct nfs3_fh *fh, char *name,
                                                                  &cs->mode);
                break;
        default:
-                ret = -EBADF;
+                /* ret = -EBADF; */
                break;
        }
 

Dont include this line in this patch. Your change has brought out a minor bug in gnfs. I'll send the correct fix for that. Thanks.
Comment 1 Shehjar Tikoo 2010-10-05 04:56:40 EDT
Minor introspection bug. Setting to 3.1.1