Bug 763131 (GLUSTER-1399)

Summary: posix_readv align to page boundary
Product: [Community] GlusterFS Reporter: Sachidananda Urs <sac>
Component: posixAssignee: Vijay Bellur <vbellur>
Status: CLOSED DUPLICATE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: amarts, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Sachidananda Urs 2010-08-19 08:46:01 UTC
Dead store  Dead assignment  xlators/storage/posix/src/posix.c  2311  1
refer:
http://dev.gluster.com/~raghavendrabhat/2010-07-14-1/report-omo64L.html#EndPath

        if (pfd->flags & O_DIRECT) {
                align = 4096;    /* align to page boundary */
        }

The align is nowhere used later in the function. What is the proper fix?

Comment 1 Amar Tumballi 2010-10-06 09:04:04 UTC
Removing it. 'align' is no more required in readv as iobuf is properly page aligned. Will be sending a bug fix for it as a part of CLANG report.

*** This bug has been marked as a duplicate of bug 1089 ***