Bug 763654 (GLUSTER-1922)
| Summary: | Volume not present wrong message displayed on command line | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Harshavardhana <fharshav> |
| Component: | cli | Assignee: | Amar Tumballi <amarts> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 3.1.0 | CC: | anush, cww, gluster-bugs, rahulcs, vijay, vraman |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | RTNR | Mount Type: | --- |
| Documentation: | DNR | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Harshavardhana
2010-10-11 23:55:29 UTC
(In reply to comment #0) > [root@platform test1]# gluster volume start vol1 > Starting volume vol1 has been unsuccessful > Volume with name vol1 does not exist > [root@platform test1]# gluster volume info vol1 > Volume vol1 not present > [root@platform test1]# > > This needs to be fixed just saying vol1 doesn't exist as "gluster volume info" > command does. hi harsha, It is not clear from the description whether you want the message "Starting volume vol1 has been unsuccessful" to be removed (or) the message "Volume with name vol1 does not exist" to be changed to "Volume vol1 does not exist"? Could you please confirm. Pranith >
> hi harsha,
> It is not clear from the description whether you want the message
> "Starting volume vol1 has been unsuccessful" to be removed (or) the message
> "Volume with name vol1 does not exist" to be changed to "Volume vol1 does not
> exist"?
> Could you please confirm.
>
> Pranith
If the requested volume is absent then the command
"gluster volume info <volname>"
Gives an output which is perfectly intuitive saying requested volume <volname> is absent.
Now the same with "gluster volume start <volname>"
Results in saying "Starting volume <volname> has been unsuccessful" now this message is a debugging message or a return value check which is not required on the terminal output.
Just the message "Volume with name <volname> does not exist" is better.
Also we can be consistent in using sentences
glusterfs volume info <volname> - Volume <volname> not present
glusterfs volume start <volname> - Volume with name <volname> does not exist.
Two sentences can be as simple as "Volume <volname> does not exist in cluster"
PATCH: http://patches.gluster.com/patch/5902 in master (glusterd,cli: print single error message on failure) The message "Volume with name <volname> does not exist" needs to be associated with every gluster command having <volname> as argument. We need to validate if <volname> is part of the command. (In reply to comment #4) > The message "Volume with name <volname> does not exist" needs to be associated > with every gluster command having <volname> as argument. > We need to validate if <volname> is part of the command. Is there any command where this error message is not showing up?. Pranith (In reply to comment #5) > (In reply to comment #4) > > The message "Volume with name <volname> does not exist" needs to be associated > > with every gluster command having <volname> as argument. > > We need to validate if <volname> is part of the command. > > Is there any command where this error message is not showing up?. > > Pranith gluster volume rebalance vol1 start It shows its unsuccessful. I have sent the necessary changes to fix this bug to rfc. Amar wants to add the cli-xdr changes as per the new document for changing xdr files as an example for the future changes. Assigning the bug to him. PATCH: http://patches.gluster.com/patch/6297 in master (gluster rebalance: get the proper/exact error msg to cli) Internal enhancement to provide exact errors. No need to mention in documentation. PATCH: http://patches.gluster.com/patch/6232 in master (Display correct usage of rebalance command when it is wrongly entered.) |