Bug 764678 (GLUSTER-2946)

Summary:	refine invocation of external commands by gsyncd
Product:	[Community] GlusterFS	Reporter:	Csaba Henk <csaba>
Component:	geo-replication	Assignee:	Csaba Henk <csaba>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	medium
Version:	mainline	CC:	gluster-bugs, kbudiger, rahulcs, vijay
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	870502 (view as bug list)		Environment:
Last Closed:		Type:	---
Regression:	RTNR	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	870502

Description Csaba Henk 2011-05-25 12:49:16 UTC

gsyncd uses os.spawn* family of functions to invoke helper programs. These functions have poor feedback capabilites. Should move to a more comprehensive approach, which could feature:

- detect if command is not possible to invoke (execve failure)
- refine handling of result beyond the "success / failure" dichotomy
- reuse error messages of external programs as log messages

Most likely candidate is subprocess module, but it's not yet investigated if it's really suitable (beyond its availability in Python >= 2.4).

Comment 1 Anand Avati 2011-08-25 09:36:47 UTC

CHANGE: http://review.gluster.com/85 (Use subprocess module instead of os.spawn* / ad-hoc fork/exec.) merged in master by Vijay Bellur (vijay)

Comment 2 Anand Avati 2012-05-19 13:11:58 UTC

CHANGE: http://review.gluster.com/3258 (geo-rep / gsyncd: fixes regarding the command invocation framework) merged in master by Vijay Bellur (vijay)

Comment 3 Vijay Bellur 2012-07-09 04:14:40 UTC

CHANGE: http://review.gluster.com/3563 (geo-rep / gsyncd: sanitize error log of external commands) merged in release-3.3 by Vijay Bellur (vijay)

Comment 4 Vijay Bellur 2012-07-15 04:08:33 UTC

CHANGE: http://review.gluster.com/3561 (geo-rep / gsyncd: sanitize error log of external commands) merged in master by Anand Avati (avati)

Comment 5 Vijay Bellur 2012-07-15 04:09:48 UTC

CHANGE: http://review.gluster.com/3560 (geo-rep / gsyncd: fixes to communication with child processes) merged in master by Anand Avati (avati)

Comment 6 Vijay Bellur 2012-07-16 09:50:36 UTC

CHANGE: http://review.gluster.com/3562 (geo-rep / gsyncd: fixes to communication with child processes) merged in release-3.3 by Vijay Bellur (vbellur)