Bug 764765 (GLUSTER-3033)

Summary:	Changes to replace-brick and syntask interface.
Product:	[Community] GlusterFS	Reporter:	krishnan parthasarathi <kparthas>
Component:	unclassified	Assignee:	krishnan parthasarathi <kparthas>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	gluster-bugs, nsathyan, saurabh, shwetha
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description krishnan parthasarathi 2011-06-15 13:59:56 UTC

This bug tracks the following changes,
- On completion of replace-brick (abort/commit), cleaning up of 
  xattrs that were used internally to maintain some state.
- Commit command to be sent via setxattr command as in the case of 
  abort.
- Fail commit operation if migration is not yet 'complete'.
- Change synctask interface to be 'universal' than just using it
  internally in pump xlator.

Comment 1 Anand Avati 2011-06-16 13:15:05 UTC

PATCH: http://patches.gluster.com/patch/7514 in master (syncop: Modified to accept one 'non-frame' arg.)

Comment 2 Anand Avati 2011-06-16 13:15:10 UTC

PATCH: http://patches.gluster.com/patch/7515 in master (afr: holding stack var via dict_set_static_bin corrupts.)

Comment 3 Anand Avati 2011-06-16 13:15:15 UTC

PATCH: http://patches.gluster.com/patch/7516 in master (glusterd: do_operation_abort and then kill dst_brick.)

Comment 4 Anand Avati 2011-06-16 13:15:21 UTC

PATCH: http://patches.gluster.com/patch/7517 in master (pump: cleanup xattrs on both commit and abort path.)

Comment 5 krishnan parthasarathi 2011-06-17 02:43:03 UTC

Steps to verify:
- Issue a replace brick (start) command from gluster CLI.
- On completion of the data migration (observed using status command), 
  issue a commit or abort command. 
- No pump related extended attributes should be see on '/' of the 'src'
  and 'dst' brick.

Comment 6 Saurabh 2011-07-01 02:47:13 UTC

please update the target milestone.

Comment 7 Shwetha H Panduranga 2011-09-05 06:30:29 UTC

This bug is verified as per the steps mentioned by krishnan parthasarathi and works fine.