Bug 764938 (GLUSTER-3206)

Summary: contrib/apple/daemon.c license problem
Product: [Community] GlusterFS Reporter: Kaleb KEITHLEY <kkeithle>
Component: coreAssignee: Vijay Bellur <vbellur>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3.2.2CC: aavati, anush, gluster-bugs, vijay
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
FreeBSD-8.2 /usr/src/lib/libc/gen/daemon.c none

Description Kaleb KEITHLEY 2011-07-20 18:07:23 UTC 
(no component for glusterfsd or contrib ???)

glusterfsd is built using .../glusterfscontrib/apple/daemon.c, taken from  http://www.opensource.apple.com/source/Libc/Libc-583/gen/FreeBSD/daemon.c

This file, the original on opensource.apple.com, and all later versions on opensource.apple.com all contain the _original_ BSD license with the advertising clause.

Fedora (and by extension, Red Hat) consider the BSD license with advertising clause to be incompatible with all versions of the GPL, and I presume, by extension, incompatible with the AGPL

Stating the obvious perhaps, but a really simple solution would be to replace daemon.c with the one from the FreeBSD 8.2 release, in /usr/src/lib/libc/gen/daemon.c (included as an attachment), which does not contain the advertising clause, and then reapply your changes. (Or perhaps your lawyers will tell you that it's okay to simply remove the advertising clause.)

If not fixed this could be an issue that might prevent including Gluster in the upcoming release of Fedora 16 and the next release of RHEL.
Comment 1 Anand Avati 2011-07-25 05:56:13 UTC 
The original intention of bringing in daemon.c was for compatibility with Mac OS systems. But down the line the file itself has undergone changes significant enough (which, are now used on all platforms) to have our own custom implementation of a daemonizing function in libglusterfs and get away with the contrib/apple/ baggage.
Comment 2 Anand Avati 2011-07-28 06:52:28 UTC 
CHANGE: http://review.gluster.com/117 (Change-Id: I72dda0bb9e3b6cfa8b8ecffe85cc606f5a682313) merged in release-3.2 by Anand Avati (avati)
Comment 3 Anand Avati 2011-07-28 06:52:43 UTC 
CHANGE: http://review.gluster.com/100 (Change-Id: I41f4635b1b75adb6d22e2e325b99941f8d7a0b42) merged in master by Anand Avati (avati)
Comment 4 Anand Avati 2011-07-28 07:02:12 UTC 
CHANGE: http://review.gluster.com/119 (Change-Id: I72dda0bb9e3b6cfa8b8ecffe85cc606f5a682313) merged in release-3.1 by Anand Avati (avati)