Bug 765200 (GLUSTER-3468)

Summary:	memory leaks in locks
Product:	[Community] GlusterFS	Reporter:	Raghavendra Bhat <rabhat>
Component:	locks	Assignee:	Raghavendra Bhat <rabhat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	pre-release	CC:	gluster-bugs, vijay
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:	glusterfs-3.2.4qa2, master (cb2c6982bd6d588a91fa2827f95f0d9cf3ff2560)	Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Raghavendra Bhat 2011-08-23 05:38:38 UTC

valgrind is reporting memory leaks in locks.


 42 bytes in 1 blocks are definitely lost in loss record 9 of 323
==21902==    at 0x4C279FC: calloc (vg_replace_malloc.c:467)
==21902==    by 0x4E7D22E: __gf_calloc (mem-pool.c:142)
==21902==    by 0x4E6644A: inode_path (inode.c:1088)
==21902==    by 0x88F6DF0: release_inode_locks_of_transport (inodelk.c:395)
==21902==    by 0x88F7A18: pl_common_inodelk (inodelk.c:594)
==21902==    by 0x88F7DF2: pl_inodelk (inodelk.c:664)
==21902==    by 0x4E5D95C: default_inodelk (defaults.c:1060)
==21902==    by 0x8D2CCE2: quota_set_inode_xattr (marker-quota.c:1202)
==21902==    by 0x8D3045D: inspect_directory_xattr (marker-quota.c:2071)
==21902==    by 0x8D309F5: quota_xattr_state (marker-quota.c:2156)
==21902==    by 0x8D2618F: marker_lookup_cbk (marker.c:2126)
==21902==    by 0x8B034CB: iot_lookup_cbk (io-threads.c:199)

1,113 (384 direct, 729 indirect) bytes in 3 blocks are definitely lost in loss record 240 of 323
==21902==    at 0x4C279FC: calloc (vg_replace_malloc.c:467)
==21902==    by 0x4E7D22E: __gf_calloc (mem-pool.c:142)
==21902==    by 0x88E9539: allocate_domain (common.c:53)
==21902==    by 0x88E97CE: get_domain (common.c:98)
==21902==    by 0x88F799D: pl_common_inodelk (inodelk.c:584)
==21902==    by 0x88F7DF2: pl_inodelk (inodelk.c:664)
==21902==    by 0x4E5D95C: default_inodelk (defaults.c:1060)
==21902==    by 0x8D2CCE2: quota_set_inode_xattr (marker-quota.c:1202)
==21902==    by 0x8D1BAFE: marker_mkdir_cbk (marker.c:469)
==21902==    by 0x8B0562A: iot_mkdir_cbk (io-threads.c:503)
==21902==    by 0x4E51AF4: default_mkdir_cbk (defaults.c:115)
==21902==    by 0x86DBBA5: posix_acl_mkdir_cbk (posix-acl.c:1043)
2,252 (768 direct, 1,484 indirect) bytes in 4 blocks are definitely lost in loss record 259 of 323
==21902==    at 0x4C279FC: calloc (vg_replace_malloc.c:467)
==21902==    by 0x4E7D22E: __gf_calloc (mem-pool.c:142)
==21902==    by 0x88F75FE: new_inode_lock (inodelk.c:521)
==21902==    by 0x88F7A45: pl_common_inodelk (inodelk.c:600)
==21902==    by 0x88F7DF2: pl_inodelk (inodelk.c:664)
==21902==    by 0x4E5D95C: default_inodelk (defaults.c:1060)
==21902==    by 0x8D2B653: update_dirty_inode (marker-quota.c:888)
==21902==    by 0x8D303D6: inspect_directory_xattr (marker-quota.c:2060)
==21902==    by 0x8D309F5: quota_xattr_state (marker-quota.c:2156)
==21902==    by 0x8D2618F: marker_lookup_cbk (marker.c:2126)
==21902==    by 0x8B034CB: iot_lookup_cbk (io-threads.c:199)
==21902==    by 0x88F25A7: pl_lookup_cbk (posix.c:1452)

Comment 1 Anand Avati 2011-08-23 14:46:09 UTC

CHANGE: http://review.gluster.com/303 (Change-Id: I352b155c065b10590a50a7195de2da40523f5710) merged in release-3.2 by Vijay Bellur (vijay)

Comment 2 Anand Avati 2011-09-20 02:39:58 UTC

CHANGE: http://review.gluster.com/465 (Change-Id: I1b7d4059610713b92c4bb78676c3b48335e3a0fe) merged in master by Vijay Bellur (vijay)

Comment 3 Raghavendra Bhat 2011-09-20 08:08:21 UTC

Checked with glusterfs-3.2.4qa2 and latest master(cb2c6982bd6d588a91fa2827f95f0d9cf3ff2560). Its fixed now. Valgrind does not report the above leak.