Bug 765278 (GLUSTER-3546)

Summary: volfile upgrade process seems kind-of kludged
Product: [Community] GlusterFS Reporter: Joe Julian <joe>
Component: buildAssignee: Lakshmipathi G <lakshmipathi>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: gluster-bugs, vijay
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: RTNR Mount Type: ---
Documentation: --- CRM:
Verified Versions: 3.2.4 Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Joe Julian 2011-09-13 13:31:16 UTC
The following process, though it may work, is not very elegant.

 glusterd --xlator-option *.upgrade=on
 sleep 10
 killall glusterd  &> /dev/null
 #start glusterd normally.

Once the upgrade option has been run couldn't glusterd just continue on? If not, couldn't glusterd exit after completing the upgrade?

Comment 1 Lakshmipathi G 2011-09-16 07:29:24 UTC
Thanks JoeJulian,Sent a patch removing those lines http://review.gluster.com/#change,425

Comment 2 Lakshmipathi G 2011-09-30 10:02:28 UTC
these changes breaks the upgrade process. 

# ps aux | grep gluster
root      7430  0.0  0.1 286328 14780 ?        Ssl  18:29   0:00 /opt/glusterfs/3.2.3/sbin/glusterfsd --xlator-option rpmch-server.listen-port=24009 -s localhost --volfile-id rpmch.10.1.12.137.rpmch11 -p /etc/glusterd/vols/rpmch/run/10.1.12.137-rpmch11.pid -S /tmp/a27687d8867f088dccee9cc1fe762992.socket --brick-name /rpmch11 --brick-port 24009 -l /var/log/glusterfs/bricks/rpmch11.log
root      7435  0.0  0.1 286328 14780 ?        Ssl  18:29   0:00 /opt/glusterfs/3.2.3/sbin/glusterfsd --xlator-option rpmch-server.listen-port=24010 -s localhost --volfile-id rpmch.10.1.12.137.rpmch21 -p /etc/glusterd/vols/rpmch/run/10.1.12.137-rpmch21.pid -S /tmp/c97c2742df4d5de17dee50d753c90a07.socket --brick-name /rpmch21 --brick-port 24010 -l /var/log/glusterfs/bricks/rpmch21.log
root      7460  2.6  0.1 138260 15620 ?        Ssl  18:29   0:00 /opt/glusterfs/3.2.3/sbin/glusterd
root      7466  0.2  0.4 235192 38636 ?        Ssl  18:29   0:00 /opt/glusterfs/3.2.3/sbin/glusterfs -f /etc/glusterd/nfs/nfs-server.vol -p /etc/glusterd/nfs/run/nfs.pid -l /var/log/glusterfs/nfs.log
root      7476  0.0  0.0  89012   780 pts/0    R+   18:30   0:00 grep gluster

# rpm -Uvh glusterfs-core-3.2.4-1.fc11.x86_64.rpm
Preparing...                ########################################### [100%]
   1:glusterfs-core         ########################################### [100%]


# ps aux | grep gluster
root      7430  0.0  0.1 286328 14780 ?        Ssl  18:29   0:00 /opt/glusterfs/3.2.3/sbin/glusterfsd --xlator-option rpmch-server.listen-port=24009 -s localhost --volfile-id rpmch.10.1.12.137.rpmch11 -p /etc/glusterd/vols/rpmch/run/10.1.12.137-rpmch11.pid -S /tmp/a27687d8867f088dccee9cc1fe762992.socket --brick-name /rpmch11 --brick-port 24009 -l /var/log/glusterfs/bricks/rpmch11.log
root      7435  0.0  0.1 286328 14780 ?        Ssl  18:29   0:00 /opt/glusterfs/3.2.3/sbin/glusterfsd --xlator-option rpmch-server.listen-port=24010 -s localhost --volfile-id rpmch.10.1.12.137.rpmch21 -p /etc/glusterd/vols/rpmch/run/10.1.12.137-rpmch21.pid -S /tmp/c97c2742df4d5de17dee50d753c90a07.socket --brick-name /rpmch21 --brick-port 24010 -l /var/log/glusterfs/bricks/rpmch21.log
root      7519 11.0  0.1 138056 15560 ?        Ssl  18:30   0:00 glusterd --xlator-option *.upgrade=on
root      7528  0.3  0.4 234868 38400 ?        Ssl  18:30   0:00 /opt/glusterfs/3.2.4/sbin/glusterfs -f /etc/glusterd/nfs/nfs-server.vol -p /etc/glusterd/nfs/run/nfs.pid -l /var/log/glusterfs/nfs.log
root      7533  0.0  0.0  89012   788 pts/0    S+   18:30   0:00 grep gluster


as you can see glusterfsd still using 3.2.3 not the new version 3.2.4. "/etc/init.d/glusterd restart " brings up the new version.

Comment 3 Anand Avati 2011-09-30 11:02:39 UTC
CHANGE: http://review.gluster.com/546 (Change-Id: Ib1c3c6f6981b07edf64aae50acad859593f36435) merged in release-3.2 by Vijay Bellur (vijay)