Bug 765336 (GLUSTER-3604)
Summary: | Streamline translator-local structure allocation | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Jeff Darcy <jdarcy> |
Component: | core | Assignee: | Amar Tumballi <amarts> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Raghavendra Bhat <rabhat> |
Severity: | low | Docs Contact: | |
Priority: | medium | ||
Version: | pre-release | CC: | gluster-bugs, vraman |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.4.0 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-07-24 17:36:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | glusterfs-3.3.0qa43 | Category: | --- |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 817967 |
Description
Jeff Darcy
2011-09-21 17:26:43 UTC
We do had plans of bringing in mempools for the local allocations. Currently Shehjar started that effort (ref: http://review.gluster.com/#dashboard,1000032 ) We also want to bring in more important logs in statedump about how many times a given type of structure is allocated (so we can decide if it is high %, make it mempool or variable sized iobuf). (ref: http://review.gluster.com/376) Considering this, I think starting on this effort right now would be bit of duplicate work. Let me know your thoughts. CHANGE: http://review.gluster.com/2772 (core: utilize mempool for frame->local allocations) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/2784 (mempool: adjustments in pool sizes) merged in master by Vijay Bellur (vijay) Now the local structure for the xlators are allocated from the mempool instead of doing malloc/free. pool-name=mirror-replicate-1:afr_local_t hot-count=1 cold-count=511 padded_sizeof=10612 alloc-count=48865 max-alloc=5 pool-misses=0 max-stdalloc=0 -----=----- pool-name=mirror-replicate-2:afr_local_t hot-count=1 cold-count=511 padded_sizeof=10612 alloc-count=42560 max-alloc=7 pool-misses=0 max-stdalloc=0 -----=----- pool-name=mirror-dht:dht_local_t hot-count=1 cold-count=511 padded_sizeof=1972 alloc-count=66128 max-alloc=6 pool-misses=0 max-stdalloc=0 -----=----- pool-name=mirror-quota:quota_local_t hot-count=1 cold-count=63 padded_sizeof=356 alloc-count=33124 max-alloc=6 pool-misses=0 max-stdalloc=0 -----=----- pool-name=mirror-write-behind:wb_local_t |