Bug 765448 (GLUSTER-3716)

Summary: setfattr trusted.iostats-dump crashes if no value is given
Product: [Community] GlusterFS Reporter: Rajesh <rajesh>
Component: unclassifiedAssignee: Rajesh <rajesh>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: mainlineCC: gluster-bugs, vagarwal
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: fuse
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Rajesh 2011-10-13 10:46:00 UTC
root@nightly:mnt# setfattr -n trusted.iostats-dump  /home/xan/mnt/m1
setfattr: /home/xan/mnt/m1: Software caused connection abort


backtrace:

(gdb) bt
#0  0x00007fa68fb2dd05 in raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux raise.c:64
#1  0x00007fa68fb31ab6 in abort () at abort.c:92
#2  0x00007fa68fb267c5 in __assert_fail (assertion=0x7fa689981963 "logfp", file=<value optimized out>, line=2133, function=<value optimized out>) at assert.c:81
#3  0x00007fa68997dbe5 in conditional_dump (dict=0x7fa67c0025d0, key=0x7fa67c0022c0 "trusted.iostats-dump", value=0x7fa67c0012c0, data=0x7fa682f30cb0)
    at io-stats.c:2133
#4  0x00007fa6906f9615 in dict_foreach (dict=0x7fa67c0025d0, fn=0x7fa68997dab4 <conditional_dump>, data=0x7fa682f30cb0) at dict.c:1218
#5  0x00007fa68997dcd8 in io_stats_setxattr (frame=0x7fa68efe8dbc, this=0x1c113f0, loc=0x7fa67c001408, dict=0x7fa67c0025d0, flags=0) at io-stats.c:2162
#6  0x00007fa68eabbb41 in fuse_setxattr_resume (state=0x7fa67c0013f0) at fuse-bridge.c:2323
#7  0x00007fa68eaad83e in fuse_resolve_and_resume (state=0x7fa67c0013f0, fn=0x7fa68eabb72d <fuse_setxattr_resume>) at fuse-resolve.c:737
#8  0x00007fa68eabbfe3 in fuse_setxattr (this=0x1bffc60, finh=0x7fa67c019c50, msg=0x7fa67c019c78) at fuse-bridge.c:2416
#9  0x00007fa68eabf8f7 in fuse_thread_proc (data=0x1bffc60) at fuse-bridge.c:3224
#10 0x00007fa68fe94d8c in start_thread (arg=0x7fa682f31700) at pthread_create.c:304
#11 0x00007fa68fbe004d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#12 0x0000000000000000 in ?? ()


Need the setfattr on client to fail gracefully in this case.

Comment 1 Anand Avati 2011-11-11 07:09:51 UTC
CHANGE: http://review.gluster.com/663 (Check for whether the dump file is given, and proceed) merged in master by Anand Avati (avati)