Bug 765470 (GLUSTER-3738)

Summary: Add-brick gives confusing error message when it fails during replace-brick.
Product: [Community] GlusterFS Reporter: Vijaykumar <vijaykumar>
Component: glusterdAssignee: krishnan parthasarathi <kparthas>
Status: CLOSED CURRENTRELEASE QA Contact: Vijaykumar Koppad <vkoppad>
Severity: medium Docs Contact:
Priority: medium    
Version: pre-releaseCC: bbandari, gluster-bugs, nsathyan, rabhat, shmohan
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-24 17:34:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: [RHEL6]-3.2.5qa4,3.3.0qa42 Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 817967    

Description Vijaykumar 2011-10-19 07:24:41 UTC
[root@RHEL6 ~]# gluster volume replace-brick doa 10.1.11.116:/export/sda/exports/exp2 10.1.11.116:/export/sda/exports/exp1 start
replace-brick started successfully

[root@RHEL6 exp1]# gluster volume info

Volume Name: doa   
Type: Distributed-Stripe
Status: Started
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: 10.1.11.116:/export/sda/exports/exp3
Brick2: 10.1.11.115:/export/sda/exports/exp3
Brick3: 10.1.11.116:/export/sda/exports/exp2
Brick4: 10.1.11.115:/export/sda/exports/exp1
Options Reconfigured:
features.limit-usage: /:1GB
features.quota: on

[root@RHEL6 exp1]# gluster volume add-brick doa 10.1.11.115:/export/sda/exports/exp4 10.1.11.116:/export/sda/exports/exp4
Volume doa: replace brick is running and the brick 10.1.11.116:/export/sda/exports/exp4 you are trying to add is the destination brick for replace brick

Even though the bricks involved in add-brick are neither part of volume nor replace-brick , it gives above error message.

Comment 1 Anand Avati 2011-10-24 10:17:38 UTC
CHANGE: http://review.gluster.com/631 (add-brick, stop-volume, remove-brick are the operations that are explicitly) merged in release-3.2 by Vijay Bellur (vijay)

Comment 2 Vijaykumar 2011-11-02 02:59:36 UTC
[root@RHEL6 ~]# gluster volume create doa stripe 2 10.1.11.115:/export/sda/exports/exp1 10.1.11.116:/export/sda/exports/exp1 10.1.11.115:/export/sda/exports/exp2 10.1.11.116:/export/sda/exports/exp2
Creation of volume doa has been successful. Please start the volume to access data.
[root@RHEL6 ~]# gluster volume start doa                                                                                                                                Starting volume doa has been successful
[root@RHEL6 ~]# gluster volume replace-brick doa 10.1.11.116:/export/sda/exports/exp2 10.1.11.115:/export/sda/exports/exp3 start                                        replace-brick started successfully
[root@RHEL6 ~]# gluster volume add-brick doa 10.1.11.115:/export/sda/exports/exp5 10.1.11.115:/export/sda/exports/exp4
Replace brick is in progress on volume doa. Please try after replace-brick operation is committed or aborted.


It gives appropriate error message now.

Comment 3 shylesh 2012-02-04 05:52:24 UTC
Reopening the bug
-----------------

upon executing the above said said steps replace-brick says "Replace-brick failed to start" and does not give appropriate message

Comment 4 krishnan parthasarathi 2012-02-12 15:43:55 UTC
@shylesh, "replace-brick failed to start" is not an inappropriate message, though I agree that it doesn't give the reason why it failed.

This bug is tracking an issue with an error message which was supplying the user with an incorrect message regarding the cause of failure of replace-brick. You should open a new bug to track inadequate error messages. This bug should be reopened only to fix an incomplete fix/patch for the original problem.

Let me know your comments, and if you agree with me, please close this bug and open a different one for the problem you see.

Comment 5 shylesh 2012-02-13 06:56:34 UTC
@kp, The fix is not yet in for master so reopened, will close once the patch is in for the master.

Comment 6 Anand Avati 2012-02-14 18:22:16 UTC
CHANGE: http://review.gluster.com/2740 (glusterd: Fail volume 'modify' operations when rb is ongoing) merged in master by Vijay Bellur (vijay)

Comment 7 krishnan parthasarathi 2012-02-23 13:19:40 UTC
*** Bug 763765 has been marked as a duplicate of this bug. ***

Comment 8 shylesh 2012-05-24 05:31:19 UTC
Now proper error messages will be shown.