| Summary: | [glusterfs-3.2.5qa6]: glusterd crashed due to abort | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Raghavendra Bhat <rabhat> |
| Component: | glusterd | Assignee: | Raghavendra Bhat <rabhat> |
| Status: | CLOSED WORKSFORME | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | medium | ||
| Version: | pre-release | CC: | amarts, gluster-bugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-11 10:22:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Raghavendra Bhat
2011-11-10 10:17:25 UTC
Even though it below code is fine for now, (considering single thread behavior of glusterd), this is very race prone..
code in 'glusterd_quota_disable()'
------
ret = glusterd_volinfo_get (volinfo, VKEY_FEATURES_LIMIT_USAGE,
"a_limits);
if (ret) {
gf_log ("", GF_LOG_WARNING, "failed to get the quota limits");
} else {
GF_FREE (quota_limits);
}
dict_del (volinfo->dict, VKEY_FEATURES_LIMIT_USAGE);
------
Here, quota_limits is the entry which is getting 'deleted' in dict_del(), but when the entry is inside the dict, its getting freed. This may lead to some problems. Not a good practice.
Johny, please check for such similar behavior in 3.3.0qa23 if it doesn't happen any more on master/release-3.3 branch, mark it UPSTREAM fixed not happening anymore with both release-3.3 branch and upstream |