Bug 765558 (GLUSTER-3826)
| Summary: | enable parallel builds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Kaleb KEITHLEY <kkeithle> | ||||
| Component: | build | Assignee: | Amar Tumballi <amarts> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Sachidananda Urs <sac> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | mainline | CC: | gluster-bugs, vraman | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | glusterfs-3.4.0 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-07-24 17:59:30 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 817967 | ||||||
| Attachments: |
|
||||||
just to be clear—— The attached patch patches both the Makefile.in and Makefile.am because it's a patch against the sources in the glusterfs-3.2.5.tgz distributed by Gluster. The fedora build only runs configure which only uses the Makefile.in. The patch patches the Makefile.am for the situation where someone runs automake before running configure. Hope that makes sense Description of problem: When using parallel make there's a race condition between running yacc on graph.y and compiling the resulting y.tab.c. Version-Release number of selected component (if applicable): All versions, but 3.2.5 in particular. How reproducible: run a `fedpkg build` or a `koji --scratch` build. The epel build seems to encounter the race condition more than the rawhide or f16 builds Steps to Reproduce: 1. See above See also https://bugzilla.redhat.com/show_bug.cgi?id=756510 Kelab, Can you go ahead and submit just the Makefile.am patch to gerrit. When we make a release out of git, the Makefile.in will be auto generated and added in tar.gz anyways. If fedora build of glusterfs-3.2.5 is maintained separately, then you can go ahead and submit this patch there, but for glusterfs, lets get it to upstream (master branch) first, and then also send a patch to release-3.2 branch. Regards, Amar CHANGE: http://review.gluster.com/763 (builds of glusterfs in the fedora build system often fail due to a) merged in master by Anand Avati (avati) Jeff Darcy found that the previous fix still manifested the race condition. I have submitted a revised fix to gerrit http://review.gluster.com/765 CHANGE: http://review.gluster.com/765 (builds of glusterfs in the fedora build system often fail due to a) merged in master by Anand Avati (avati) I'm not sure why comment #1 and attachment 721 [details] are XF86Config files. Looks like something was borken in the bugzilla migration. And I thought this was closed already. Lets close once QA verifies this is working. Agreed we should close once QA verifies the official gluster build. https://bugzilla.redhat.com/show_bug.cgi?id=756510 is the BZ for the canonical f16 build, and it's already been auto-closed by Koji. Not present in release 3.3.0, will verify later. I don't see that this has been addressed in any branch of glusterfs. I still have to patch the libglusterfs/src/Makefile.am (and Makefile.in) to build in koji for fedora for all releases of 3.2.x and 3.3.0 |
Created attachment 721 [details] My XF86Config file