Bug 765698

Summary:	Improve virsh nodesuspend output information
Product:	Red Hat Enterprise Linux 6	Reporter:	Alex Jia <ajia>
Component:	libvirt	Assignee:	Peter Krempa <pkrempa>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.3	CC:	acathrow, dallan, dyuan, mzhan, rwu, weizhan, yupzhang, zhpeng
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-0.9.9-1.el6	Doc Type:	Bug Fix
Doc Text:	No Documentation needed	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 06:38:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alex Jia 2011-12-09 06:40:47 UTC

Description of problem:
Run 'virsh nodesuspend mem disk' then check return value, which is '1', but can't see any error output and also can't find error in libvirtd.log or /var/log/messages.

Version-Release number of selected component (if applicable):
libvirt-0.9.8-0rc2.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1. virsh nodesuspend mem disk (mix 'mem' and 'disk' options)
2. check output, logs and return value 
  
Actual results:
# virsh nodesuspend mem disk

Note: nothing error output in here.
# echo $?
1

Note: but return value is 1, and also can't see error in related logs file.

Expected results:
Raising error information and writing them into libvirtd.log file.

Additional info:

Comment 1 zhpeng 2011-12-13 09:54:32 UTC

The same issue with libvirt-0.9.8-1.el6.x86_64

Comment 2 Peter Krempa 2011-12-13 14:40:03 UTC

Fixed with upstream commit:

commit b72c774b88b911a78d3040c02dc03c2411edd2d7
Author: Peter Krempa <pkrempa>
Date:   Tue Dec 13 14:50:30 2011 +0100

    virsh: Print error message if argument parsing fails for cmdNodesuspend
    
    If parsing of arguments failed, virsh did silently exit returning and
    error state, but not specifying the possible problem.


Errors are printed if parsing of arguments fails.

Comment 4 yuping zhang 2012-01-10 02:59:01 UTC

Verified this issue with libvirt-0.9.9-1.el6.x86_64.
# virsh nodesuspend mem disk
error: Invalid duration argument

# echo $?
1

So change the bug status to VERIFIED.

Comment 5 Peter Krempa 2012-05-02 09:43:42 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation needed

Comment 7 errata-xmlrpc 2012-06-20 06:38:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html