Bug 765888

issue seems to be: having already a promotion passed and making a second try to the same org/env (but different promotion name).

I've reproduced this problem, when the first promotion was made prior to synchronization. It seems Pulp ends up then with the following error:

    2011-12-09 17:38:05,886 2537:139878796867328: pulp.server.api.repo_sync:ERROR: repo_sync:141 Cannot retrieve repository metadata (repomd.xml) for repository: /tmp/temp_pulp_repoS6sW6Y. Please verify its path and try again
    2011-12-09 17:38:05,888 2537:139878796867328: pulp.server.api.repo_sync:WARNING: repo_sync:142 Traceback: Traceback (most recent call last):
    File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 136, in _clone
    _sync(clone_id, progress_callback=progress_callback, synchronizer=synchronizer)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 272, in _sync
    progress_callback, synchronizer, max_speed, threads)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 350, in fetch_content
    progress_callback, max_speed, threads)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/synchronizers.py", line 158, in sync
    max_speed=max_speed, threads=threads)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/synchronizers.py", line 1116, in local
    progress_callback)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/synchronizers.py", line 871, in _sync_rpms
    unfiltered_pkglist = pulp.server.util.get_repo_packages(src_repo_dir)
    File "/usr/lib/python2.7/site-packages/pulp/server/util.py", line 307, in get_repo_packages
    sack.populate(r, 'metadata', None, 0)
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 164, in populate
    if self._check_db_version(repo, mydbtype):
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 222, in _check_db_version
    return repo._check_db_version(mdtype)
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1255, in _check_db_version
    repoXML = self.repoXML
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1454, in <lambda>
    repoXML = property(fget=lambda self: self._getRepoXML(),
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1450, in _getRepoXML
    raise Errors.RepoError, msg
    RepoError: Cannot retrieve repository metadata (repomd.xml) for repository: /tmp/temp_pulp_repoS6sW6Y. Please verify its path and try again
     
    2011-12-09 17:38:05,888 2537:139878796867328: pulp.server.tasking.task:ERROR: task:455 Task failed: Task 2abe3d82-2284-11e1-9034-f0def16f6678: _clone(ACME_Corporation-Dev-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_62_x86_64, feed=parent, progress_callback=<bound method RepoCloneTask.progress_callback of <pulp.server.api.repo_clone_task.RepoCloneTask object at 0x7f380813e490>>, clone_name=Red Hat Enterprise Linux 6 Server RPMs 62 x86_64, relative_path=ACME_Corporation/Dev/content/dist/rhel/server/6/6.2/x86_64/os, synchronizer=<pulp.server.api.synchronizers.YumSynchronizer object at 0x7f380813e8d0>, filters=[], id=ACME_Corporation-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_62_x86_64, groupid=['product:69', 'env:2', 'org:1', 'content:168'])
    Traceback (most recent call last):
    File "/usr/lib/python2.7/site-packages/pulp/server/tasking/task.py", line 404, in run
    result = self.callable(*self.args, **self.kwargs)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 136, in _clone
    _sync(clone_id, progress_callback=progress_callback, synchronizer=synchronizer)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 272, in _sync
    progress_callback, synchronizer, max_speed, threads)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 350, in fetch_content
    progress_callback, max_speed, threads)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/synchronizers.py", line 158, in sync
    max_speed=max_speed, threads=threads)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/synchronizers.py", line 1116, in local
    progress_callback)
    File "/usr/lib/python2.7/site-packages/pulp/server/api/synchronizers.py", line 871, in _sync_rpms
    unfiltered_pkglist = pulp.server.util.get_repo_packages(src_repo_dir)
    File "/usr/lib/python2.7/site-packages/pulp/server/util.py", line 307, in get_repo_packages
    sack.populate(r, 'metadata', None, 0)
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 164, in populate
    if self._check_db_version(repo, mydbtype):
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 222, in _check_db_version
    return repo._check_db_version(mdtype)
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1255, in _check_db_version
    repoXML = self.repoXML
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1454, in <lambda>
    repoXML = property(fget=lambda self: self._getRepoXML(),
    File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1450, in _getRepoXML
    raise Errors.RepoError, msg
    RepoError: Cannot retrieve repository metadata (repomd.xml) for repository: /tmp/temp_pulp_repoS6sW6Y. Please verify its path and try again

However, there is no error showed on the Katello side. This error prevents creation of an association between repo and it's clone in Pulp (all clone_ids are empty, even if the cloned repos are already there).

Due to missing this association, Katello is not aware of the existing clone and tries to clone it again in next promotion. This causes the validation error on pulp_id (because a record is aready created from the previous try)

*** Bug 765962 has been marked as a duplicate of this bug. ***

The bug above is not a duplicate of this one

Two issues:

1) We do not report error when an async task fails. We need to properly report those errors in Katello.

2) We should not allow to promote an empty repo.

Working on the 2)

Taking the 1)

Number 1 fixed in version katello-0.1.139-1

commit 1542d8c21802b56b79a102685a38c9f6c23f2661
async tasks - raising exception when a task fails while waiting until it finishes

Waiting for number 2.

Note to myself: empty repo is UNSYNCHRONIZED repo in this context.

Empty repo is okay: http://lzap.fedorapeople.org/fakerepos/empty/

   def add_product cpid
     product = find_product_by_cpid(cpid)
+
+    # check if product was already synced
+    raise _("Product '#{product.name}' was not synchronized yet") if product.last_sync.nil?
+
     self.products << product
     product
   end


0f5c9f7 765888 - Error during promotion

The problem with repositories not being promoted before synchronization relates to the bug on Pulp side:

https://bugzilla.redhat.com/show_bug.cgi?id=760310

With the fix on the Pulp side there is no need to check the sync status before promotion.

Ok I will revert the patch as it was fixed in Pulp.

commit 82f3f7b72e758238a4d81997714f2db6113bdad8
Refs: keys, katello-configure-0.1.42-1-6-g82f3f7b
Author:     Lukas Zapletal <lzap+git>
AuthorDate: Mon Dec 19 18:15:36 2011 +0100
Commit:     Lukas Zapletal <lzap+git>
CommitDate: Mon Dec 19 18:42:42 2011 +0100

    Revert "765888 - Error during promotion"

# VERIFIED

Trying with scenarios of import manifest/sync repo/promoting, re-promoting content - all works fine so far.

Please fill free to reopen this bug or another defect related to the Red Hat provider's manifest import/sync/promotion.

As an CDN was used: http://inecas.fedorapeople.org/fakerepos/cds/ (and the fake -manifest-syncable.zip)

a note: promoting empty repos is allowed and is ok now.

Checked against:
---

katello-0.1.235-1.git.0.737ec3f.el6.noarch
katello-cli-0.1.54-1.git.0.2670189.el6.noarch
pulp-0.0.265-1.el6.noarch
candlepin-0.5.17-1.el6.noarch