Bug 766622

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3579619

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
[-]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[!]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[!]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/contyk/src/review/766622/Authen-Credential-0.5.tar.gz :
  MD5SUM this package     : 32fd2003715f1b4bb010ac4a5e477ca7
  MD5SUM upstream package : 32fd2003715f1b4bb010ac4a5e477ca7

[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[-]: SHOULD Spec use %global instead of %define.

Issues:
TODO: Please, remove the Buildroot tag, the %clean section, the buildroot removal in %build section and %defattr from files unless you plan to use this package in EPEL5.  Those are now obsolete in Fedora.
TODO: Add BuildRequires: perl(Exporter)
TODO: Since it seems you'd like to run optional POD tests, specify the needed POD modules versions in BR, i.e.: perl(Pod::Coverage) >= 0.18 and perl(Test::Pod::Coverage) >= 1.08
TODO: Remove unneeded runtime dependencies polluting the resulting RPM.  rpm adds those automatically. Those are perl(MIME::Base64), perl(Params::Validate), and perl(URI::Escape)

Generated by fedora-review 0.1.1
External plugins:

Spec URL: http://lfield.web.cern.ch/lfield/fedora/perl-Authen-Credential.spec
SRPM URL:
http://lfield.web.cern.ch/lfield/fedora/perl-Authen-Credential-0.5-2.fc16.src.rpm

Here is an updated version with the suggested improvements. Please note that we are targeting EPEL5.

(In reply to comment #3)
> Here is an updated version with the suggested improvements. Please note that we
> are targeting EPEL5.

Ok.

Approving.  Sorry for the delay, I missed the update.

New Package SCM Request
=======================
Package Name: : perl-Authen-Credential
Short Description: Abstraction of a credential
Owners: lfield
Branches: f16 el5 el6
InitialCC:

Git done (by process-git-requests).

Removed spurious colon.

Perl packages should in principal have perl-sig added as an 'initialCC'   though this is just
a request.

perl-Authen-Credential-0.5-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Authen-Credential-0.5-2.el6

perl-Authen-Credential-0.5-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Authen-Credential-0.5-2.el5

perl-Authen-Credential-0.5-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-Authen-Credential-0.5-2.fc16

perl-Authen-Credential-0.5-2.el5 has been pushed to the Fedora EPEL 5 testing repository.

perl-Authen-Credential-0.5-2.fc16 has been pushed to the Fedora 16 stable repository.

perl-Authen-Credential-0.5-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

perl-Authen-Credential-0.5-2.el6 has been pushed to the Fedora EPEL 6 stable repository.