Bug 767082
| Summary: | Review Request: wxpropgrid - A property sheet control for wxWidgets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Volker Fröhlich <volker27> |
| Component: | Package Review | Assignee: | Jerry James <loganjerry> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alain.portal, alain.portal, dan, loganjerry, notting, package-review |
| Target Milestone: | --- | Flags: | loganjerry:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | wxpropgrid-1.4.15-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-05 21:51:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 585719, 737401 | ||
|
Description
Volker Fröhlich
2011-12-13 07:41:11 UTC
I'll take this review. LEGEND: +: OK -: must be fixed =: should be fixed (at your discretion) N: not applicable MUST: [=] rpmlint output: wxpropgrid.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets wxpropgrid.x86_64: W: spelling-error %description -l en_US wxPropertyGrid -> expropriated wxpropgrid.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxpropgrid.x86_64: W: spelling-error %description -l en_US flagsets -> flag sets, flag-sets, flatlets wxpropgrid.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libwxcode_gtk2u_propgrid-2.8.so.0.0.0 linux-vdso.so.1 2 packages and 1 specfiles checked; 0 errors, 5 warnings. Those are all innocuous. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license [+] license field matches the actual license [N] license file is included in %doc: upstream does not ship it. [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum is f44b5cd6fd60718bacfabbf7994f1e93 for both [+] package builds on at least one primary arch (tried x86_64) [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [+] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [+] header files in -devel [N] static libraries in -static [+] .so in -devel [+] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [+] query upstream for license text: has been done, as noted in the spec file. [N] description and summary contain available translations [+] package builds in mock: tried fedora-rawhide-i386 [+] package builds on all supported arches: tried i386 and x86_64 [+] package functions as described: light testing only [+] sane scriptlets [+] subpackages require the main package [N] placement of pkgconfig files [N] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts Everything looks great. This package is APPROVED. Thanks again! New Package SCM Request ======================= Package Name: wxpropgrid Short Description: A property sheet control for wxWidgets Owners: volter Branches: f15 f16 el6 InitialCC: Git done (by process-git-requests). Volker, could you please request for EPEL branch? Your package build fine in EPEL: http://koji.fedoraproject.org/koji/taskinfo?taskID=3741465 and I'll need it to package wxformbuilder in EPEL. Thanks. (In reply to comment #7) > Alain, please see comment 4. Sorry for the noise, I really need to change my glasses ;-) Thanks for this package! And feel free to take some others bundled libraries in wxformbuilder ;-) wxpropgrid-1.4.15-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/wxpropgrid-1.4.15-1.el6 wxpropgrid-1.4.15-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wxpropgrid-1.4.15-1.fc15 wxpropgrid-1.4.15-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/wxpropgrid-1.4.15-1.fc16 wxpropgrid-1.4.15-1.el6 has been pushed to the Fedora EPEL 6 testing repository. wxpropgrid-1.4.15-1.fc15 has been pushed to the Fedora 15 stable repository. wxpropgrid-1.4.15-1.fc16 has been pushed to the Fedora 16 stable repository. wxpropgrid-1.4.15-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |