| Summary: | [ovirt] [vdsm] extend of thin provisioned disk fails | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Haim <hateya> | ||||
| Component: | vdsm | Assignee: | Federico Simoncelli <fsimonce> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | unspecified | CC: | abaron, acathrow, bazulay, danken, iheim, mgoldboi, yeylon, ykaul | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | v4.9.3 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-08-09 08:01:00 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
Created attachment 546138 [details]
vdsm log
Proposed fix:
commit 8fc03681cdc88f9bf7adc7418bbdbf7d072e9530
Author: Federico Simoncelli <fsimonce>
Date: Tue Dec 13 09:37:41 2011 +0000
BZ#767111 Extend volume size must be in Megabyte
In commit c24396af (Merged SPM to StoragePool and HSM) the
spm.public_extendVolume call was replaced by pool.extendVolume.
The problem is that they use different units for the size
parameter, the first one uses bytes and the second one uses
megabytes.
In this patch:
* do not convert megabytes to bytes when calling pool.extendVolume
* improve logging to record also the size received from the mailbox
Change-Id: I955da5ca52708eb9bfd51df66f2a0e13e8eaf3c8
http://gerrit.ovirt.org/579
closing ON_QA bugs as oVirt 3.1 was released: http://www.ovirt.org/get-ovirt/ |
Description of problem: case: - run vm - perform snapshot - run 'dd' so disk will get bigger at certain point, when water mark reach its designated threshold, extend message is sent to spm mailbox, but fails claiming that domain size (i.e, vg) is not bug enough, whereas, in-fact, vg free size is standing on 80g, and request size is 1024m. request is correct but then the command is wrong: Thread-52962::DEBUG::2011-12-13 11:34:14,044::vm::557::vm.Vm::(_lvExtend) vmId=`2dfd58aa-d689-422b-a720-9ce865e2aaa0`::7ed87246-a042-4517-8613-9db0a8a2a3c2/50d9bc13-1666-49f0-aacb-d1b8c7785763 (vda): apparentsize 1024 req 2048 bb95a755-adc2-46ff-8461-f3688732908a::DEBUG::2011-12-13 11:34:14,570::lvm::385::Storage.Misc.excCmd::(cmd) '/usr/bin/sudo -n /sbin/lvm lvextend --config " devices { preferred_names = [\\"^/dev/mapper/\\"] ignore_suspended_devices=1 write_cache_state=0 disable_after_error_count=3 filter = [ \\"a%1UpstreamCluster-SD31320589|1UpstreamCluster112924773|1UpstreamCluster212924773|1UpstreamCluster312924773%\\",\\"r%.*%\\" ] } global { locking_type=1 prioritise_write_locks=1 wait_for_locks=1 } backup { retain_min = 50 retain_days = 0 } " --autobackup n --size 2147483648m 7ed87246-a042-4517-8613-9db0a8a2a3c2/50d9bc13-1666-49f0-aacb-d1b8c7785763' (cwd None)