Bug 767232

Summary:	test commands in cumin build
Product:	Red Hat Enterprise MRG	Reporter:	Stanislav Graf <sgraf>
Component:	cumin	Assignee:	Trevor McKay <tmckay>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Peter Belanyi <pbelanyi>
Severity:	unspecified	Docs Contact:
Priority:	low
Version:	2.0	CC:	athomas, esammons, ltoscano, matt, mkudlej, pbelanyi, tmckay
Target Milestone:	3.0
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cumin-0.1.5251-1	Doc Type:	Bug Fix
Doc Text:	Cause Certain development test programs were included in the Cumin installation. Additionally, cumin-database and cumin-admin which require root privilege were located in /usr/bin instead of /usr/sbin/ Consequence The test programs are unnecessary for end users and are not documented. Including them and placing cumin-admin and cumin-database in /usr/bin could cause confusion. Change Eliminated the test programs from the installation and relocated cumin-admin and cumin-database to /usr/sbin. Result Only appropriate programs are included in the installation and they are installed in the appropriate locations.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-05-06 13:52:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Stanislav Graf 2011-12-13 15:18:56 UTC

Description of problem:
There are test commands in cumin RPM. We should not ship them:
/usr/bin/cumin-admin-test
/usr/bin/cumin-command-test
/usr/bin/cumin-data-test
/usr/bin/cumin-smoke-test
/usr/bin/cumin-web-test

Version-Release number of selected component (if applicable):
cumin-0.1.5098-2

How reproducible:
100%

Steps to Reproduce:
1. repoquery --query cumin --list | grep /usr/bin
  
Actual results:
-test commands present

Expected results:
-test commands missing

Additional info:

Comment 1 Trevor McKay 2011-12-13 15:34:17 UTC

Also, move root-only programs to /usr/sbin instead of /usr/bin.

Comment 2 Trevor McKay 2012-02-10 19:20:00 UTC

Note, cumin-bench and cumin-smoke-test both fail.  They should be fixed in the repo, even if not shipped.

Comment 3 Trevor McKay 2012-02-13 18:54:51 UTC

Fixed in revision 5217.

Cumin.spec changed to install cumin-admin and cumin-database in /usr/sbin

Comment 4 Trevor McKay 2012-02-14 18:34:54 UTC

Also requires change to sysvinit script.

Fixed in revision 5219

Comment 5 Trevor McKay 2012-03-01 14:52:03 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    Certain development test programs were included in the Cumin installation.  Additionally, cumin-database and cumin-admin which require root privilege were located in /usr/bin instead of /usr/sbin/

Consequence
    The test programs are unnecessary for end users and are not documented.  Including them and placing cumin-admin and cumin-database in /usr/bin could cause confusion.

Change
    Eliminated the test programs from the installation and relocated cumin-admin and cumin-database to /usr/sbin.

Result
    Only appropriate programs are included in the installation and they are installed in the appropriate locations.

Comment 8 Trevor McKay 2012-10-03 15:21:49 UTC

For testing, this is "state of the art"

cumin-checkpid originated in Bug 801287
cumin-report originated in Bug 807838

# rpm -ql cumin | grep /usr/bin
/usr/bin/cumin
/usr/bin/cumin-data
/usr/bin/cumin-report
/usr/bin/cumin-web

# rpm -ql cumin | grep /usr/sbin
/usr/sbin/cumin-admin
/usr/sbin/cumin-checkpid
/usr/sbin/cumin-database

Comment 9 Peter Belanyi 2013-04-04 09:31:32 UTC

Reproduced on cumin-0.1.5192-4

Tested on RHEL 5/6 i386/x86_64
cumin-0.1.5675-1

Everything is as expected.

--> VERIFIED