Bug 767264
| Summary: | fedpkg should bail out when small textual file is being uploaded to lookaside cache | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Mraz <tmraz> | ||||
| Component: | rpkg | Assignee: | Ondřej Nosek <onosek> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | araszka, cqi, onosek | ||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2020-05-06 00:41:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Pull-request: https://pagure.io/rpkg/pull-request/13 This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions While releasing a version of fedpkg, got [a feedback from a package maintainer](https://bodhi.fedoraproject.org/updates/fedpkg-1.24-3.fc24#comment-456383), that is he sometimes uses lookaside to manage (large) patches. It could be kind of difficult to know how every packager maintainer uses lookaside to track "small" files other than a tarball. This change introduced in patch forces not to push a "small" file and raise an error, this would be too noisy to package maintainers if they really use lookaside to manage such files. Leave this bug open here and to see feedback from more package maintainers. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. With no feedback in 6 months, is it maybe time to revisit this? Either revive the patch and merge it or close it as WONTFIX. This issue has been unresolved for more than a year, and is going to be closed within a week if no further action is taken. If you feel this is in error, please contact me. This is a cleaning process suggested by Jay Greguske. Copy of this ticket was already closed in JIRA tracker. This package has changed maintainer in the Fedora. Reassigning to the new maintainer of this component. |
Created attachment 546289 [details] Proof of the concept patch There was the recent discussion in FESCo and on fedora-devel mailing list about preventing upload of small textual files to lookaside cache. This should not be prevented ultimately though, so it should be overridable with --force flag. The attached crude patch achieves that with calling 'file' tool on the file to identify it.