Bug 767323

Summary: deployable uuid improperly validated before delete
Product: [Retired] CloudForms Cloud Engine Reporter: Dan Radez <dradez>
Component: aeolus-configserverAssignee: dgao
Status: CLOSED ERRATA QA Contact: dgao
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: akarol, asettle, deltacloud-maint, gblomqui, juwu, morazi, ssachdev, whayutin
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
When deleting an application on Conductor, aeolus-configserver cannot correctly validate the application UUID and returns a 404 error. This bug fix updates aeolus-configserver, so when an application is deleted, the associated configuration files on aeolus-configserver will also be deleted.
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 14:53:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
could_not_delete_running_audrey_applications
none
delete_success none

Description Dan Radez 2011-12-13 19:39:45 UTC
Description of problem:
When configserver goes to delete a deployment it looks in the list of instances to validate against.

Version-Release number of selected component (if applicable):
0.4.3

How reproducible:
any call to delete /deployment

Steps to Reproduce:
1. any call to delete /deployment
2.
3.
  
Actual results:
can't delete a real deployment, returns 404

Expected results:
deployment is deleted

Additional info:

Comment 1 wes hayutin 2011-12-14 16:28:17 UTC
moving to version cf-1.0.0

Comment 2 Greg Blomquist 2011-12-22 15:12:26 UTC
Dan, didn't you fix this already?  I thought you already implemented "deployment_exists?"

Should this still be assigned?  Or, should this be marked as modified, or on_qa?

Comment 3 Dan Radez 2012-01-03 14:33:44 UTC
I did fix this and pushed the code, the bug just didn't make it to modified,
commit 342ddd3c743d449ed88914ad941386f46874dea4g

Comment 4 wes hayutin 2012-01-03 17:42:09 UTC
adding ce-sprint-next bugs to ce-sprint

Comment 5 Shveta 2012-03-02 11:20:32 UTC
Launched few instances for audrey configserver .
Tried to delete running applications.
Could not delete..http://pastebin.test.redhat.com/79007

Is this what is supposed to be checked?

If yes , then bug is not fixed yet.

Comment 6 Shveta 2012-03-02 13:04:55 UTC
changing the status to assigned

rpm -qa|grep aeolus
aeolus-conductor-doc-0.8.0-39.el6.noarch
rubygem-aeolus-cli-0.3.0-12.el6.noarch
aeolus-all-0.8.0-39.el6.noarch
aeolus-conductor-0.8.0-39.el6.noarch
rubygem-aeolus-image-0.3.0-11.el6.noarch
aeolus-configure-2.5.0-16.el6.noarch
aeolus-conductor-daemons-0.8.0-39.el6.noarch

Comment 7 Shveta 2012-03-02 13:05:36 UTC
Created attachment 567054 [details]
could_not_delete_running_audrey_applications

Comment 8 Dan Radez 2012-03-06 18:34:08 UTC
aeolus-configserver-0.4.6-1 has been built and tagged from commit a983ca501baad3e00a3192913d06b139c06bb2c2

Comment 9 Dan Radez 2012-03-06 21:48:24 UTC
sry the last hash was not for this bug, reverting status

Comment 10 wes hayutin 2012-04-17 21:00:31 UTC
Dan.. why would config server ever try to delete an instance?

Comment 11 Dan Radez 2012-04-18 13:02:24 UTC
when conductor deletes an instance it should delete the configs out of CS too

Comment 12 dgao 2012-05-02 19:04:41 UTC
Created attachment 581696 [details]
delete_success

instance folder disappeared in /var/lib/aeolus-configserver/config/instances/

in /var/log/aeolus-configserver/thin.log

10.16.76.33 - - [02/May/2012 15:01:01] "DELETE /deployment/1/6e473ccc-9488-11e1-8661-00215e203950 HTTP/1.1" 200 85 0.0046


[root@deaddonkey aeolus-configserver]# rpm -qa | grep "aeolus-configserver"
aeolus-configserver-0.4.8-1.el6_2.noarch

Comment 15 errata-xmlrpc 2012-12-04 14:53:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-1516.html