Bug 767475

Summary: Add/Remove options shouldn't be active when no package name supplied in the text box.
Product: Red Hat Satellite Reporter: Sachin Ghai <sghai>
Component: WebUIAssignee: Brad Buckingham <bbuckingham>
Status: CLOSED CURRENTRELEASE QA Contact: Katello QA List <katello-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.1CC: mmccune
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-22 18:13:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Add/Remove options are active when no package is specified in text box
none
Disabled add/remove links when no input is supplied in text box none

Description Sachin Ghai 2011-12-14 07:08:28 UTC
Description of problem:
I registered a machine using RHSM and was trying to add a package on newly registered system. I selected the system and on right pane under "packages" tab I found "ADD and "Remove" options. 

Without specify the package name, Add and Remove options were active and when I clicked on it, following notification generated:

>> Success 	Install of Packages '' scheduled for System 'dhcp201-107.englab.pnq.redhat.com'.

Notice that no package name is here between the quotes.

Also following logs generated in production.log:
=======

2011-12-14 12:28:54,420 18481:139968110376704: gofer.rmi.policy:INFO: policy:139 sent (8a317386-424c-48d5-bf19-a7f2464f5d2d):
{
  "classname": "Packages", 
  "kws": {}, 
  "args": [
    [], 
    false
  ], 
  "method": "install", 
  "cntr": [
    [], 
    {
      "importkeys": false
    }
  ]
}
2011-12-14 12:29:04,994 18481:139968110376704: pulp.server.tasking.task:ERROR: task:455 Task failed: Task 1499978f-2621-11e1-938b-525400a33cb8: ConsumerApi.__installpackages(8a317386-424c-48d5-bf19-a7f2464f5d2d, [], )
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/pulp/server/tasking/task.py", line 404, in run
    result = self.callable(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/pulp/server/api/consumer.py", line 456, in __installpackages
    return packages.install(names, reboot)
  File "/usr/lib/python2.6/site-packages/gofer/rmi/stub.py", line 72, in __call__
    return self.stub._send(request, opts)
  File "/usr/lib/python2.6/site-packages/gofer/rmi/stub.py", line 133, in _send
    return self.__send(request, options)
  File "/usr/lib/python2.6/site-packages/gofer/rmi/stub.py", line 164, in __send
    any=opts.any)
  File "/usr/lib/python2.6/site-packages/gofer/rmi/policy.py", line 143, in send
    self.__getstarted(sn, reader)
  File "/usr/lib/python2.6/site-packages/gofer/rmi/policy.py", line 166, in __getstarted
    raise RequestTimeout(sn, 0)
RequestTimeout: ('ce80014e-ebd2-4c9f-9437-6cf7459a8a62', 0)


Version-Release number of selected component (if applicable):
[root@dhcp201-220 ~]# rpm -qa | grep katello
katello-0.1.135-2.el6.x86_64
katello-configure-0.1.31-2.el6.noarch
katello-glue-candlepin-0.1.135-2.el6.x86_64
katello-qpid-broker-key-pair-1.0-1.noarch
katello-cli-0.1.23-3.el6.noarch
katello-trusted-ssl-cert-1.0-1.noarch
katello-cli-common-0.1.23-3.el6.noarch
katello-glue-pulp-0.1.135-2.el6.x86_64
katello-all-0.1.135-2.el6.x86_64
katello-glue-foreman-0.1.135-2.el6.x86_64
katello-common-0.1.135-2.el6.noarch
katello-httpd-ssl-key-pair-1.0-1.noarch
katello-certs-tools-1.0.1-2.el6.noarch
[root@dhcp201-220 ~]# 


How reproducible:
always

Steps to Reproduce:
1. register a system 
2. select the system and on right pane select 'Packages"
3. click on +Add or -Remove buttons
  
Actual results:
+Add and -remove are active without even specifying the package names

Expected results:
+Add -Remove shouldn't be active when no package name is supplied

Additional info:

Comment 1 Sachin Ghai 2011-12-14 07:10:04 UTC
Created attachment 546594 [details]
Add/Remove options are active when no package is specified in text box

Comment 2 Brad Buckingham 2012-01-25 22:50:16 UTC
commit - ab03f27600a636677383fe419e4e2fb7661bbe6a

Add/Remove links are disabled on initial load of pane.
Add/Remove links are enabled when user enters text in input box and disable when box is empty.

Comment 3 Mike McCune 2012-01-26 19:02:16 UTC
ON_QA

Comment 4 Sachin Ghai 2012-01-31 15:41:36 UTC
verified with following katello build:

katello-0.1.206-1.el6.noarch


Now Add/Remove links are disabled on initial load as well as when text box is empty. Please see attachment in next comment

Comment 5 Sachin Ghai 2012-01-31 15:43:23 UTC
Created attachment 558636 [details]
Disabled add/remove links when no input is supplied in text box

Comment 7 Mike McCune 2013-08-16 18:01:23 UTC
getting rid of 6.0.0 version since that doesn't exist