Bug 767556
Summary: | Review Request: scl-utils - Utilities for alternative packaging | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jindrich Novy <jnovy> |
Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, pknirsch, pkovar |
Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-01-03 15:31:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jindrich Novy
2011-12-14 11:09:57 UTC
rpmlint scl-utils-20111209-1.fc16.src.rpm scl-utils.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) rpmlint ../rpmbuild/RPMS/x86_64/scl-utils-* scl-utils.x86_64: W: obsolete-not-provided stack scl-utils.x86_64: W: no-documentation scl-utils.x86_64: E: dir-or-file-in-opt /opt/rh scl-utils.x86_64: W: no-manual-page-for-binary scl scl-utils.x86_64: W: no-manual-page-for-binary scl_enabled scl-utils-build.x86_64: W: obsolete-not-provided stack-build scl-utils-build.x86_64: W: no-documentation scl-utils-build.x86_64: W: non-conffile-in-etc /etc/rpm/macros.dsc scl-utils-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/scl-utils-20111209/scl.c I suggest add the buildroot macro, because it might be needed in EPEL-5. Same problem with the clean section and defattr in the files section and "rm -rf" in the install section. Obsoleted and not provided stack is probably ok, but it might be possible to remove stack at all, because it was never officially built. Please, fix fsf address. This would be one of many unfixable reviews ;-) (In reply to comment #1) > rpmlint scl-utils-20111209-1.fc16.src.rpm > scl-utils.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line Fixed. > 1) > > rpmlint ../rpmbuild/RPMS/x86_64/scl-utils-* > scl-utils.x86_64: W: obsolete-not-provided stack The stack obsolete was removed. > scl-utils.x86_64: W: no-documentation > scl-utils.x86_64: E: dir-or-file-in-opt /opt/rh > scl-utils.x86_64: W: no-manual-page-for-binary scl > scl-utils.x86_64: W: no-manual-page-for-binary scl_enabled > scl-utils-build.x86_64: W: obsolete-not-provided stack-build > scl-utils-build.x86_64: W: no-documentation > scl-utils-build.x86_64: W: non-conffile-in-etc /etc/rpm/macros.dsc > scl-utils-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/scl-utils-20111209/scl.c > > I suggest add the buildroot macro, because it might be needed in EPEL-5. The package already contains: Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > Same > problem with the clean section and defattr in the files section and "rm -rf" in > the install section. > > Obsoleted and not provided stack is probably ok, but it might be possible to > remove stack at all, because it was never officially built. > Please, fix fsf address. This would be one of many unfixable reviews ;-) Given that I'm actually upstream there is not a problem to fix the address. It is done now :) New packages: Spec URL: http://jnovy.fedorapeople.org/scl-utils/scl-utils.spec SRPM URL: http://jnovy.fedorapeople.org/scl-utils/scl-utils-20111214-1.fc16.src.rpm - rpmlint OK - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license OK - license field GPLv2+ must match actual license OK - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build OK http://koji.fedoraproject.org/koji/taskinfo?taskID=3584414 - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires OK - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK APPROVED New Package SCM Request ======================= Package Name: scl-utils Short Description: Utilities for alternative packaging Owners: jnovy Branches: f15 f16 el6 el5 InitialCC: Git done (by process-git-requests). scl-utils are now included in rawhide/f15/f16/el5/el6 and new package updates are relased. |