Bug 768028

Summary:	F16 doesn't build in Factory
Product:	[Retired] CloudForms Cloud Engine	Reporter:	Ian McLeod <imcleod>
Component:	imagefactory	Assignee:	Ian McLeod <imcleod>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Martin Kočí <mkoci>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	1.0.0	CC:	akarol, brad, dajohnso, deltacloud-maint, dgao, jvlcek, morazi, ssachdev, whayutin
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-30 17:15:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Ian McLeod 2011-12-15 14:57:53 UTC

F16 fails to build for upload style builds due to relocation of the /boot partition.

Boot for all existing supported RHEL and Fedora versions ends up as /dev/sda1.  For F16, due I believe to GRUB changes, it is sda2.  Some of our customization code assumes sda1.

Need to add some intelligence to detect this and behave accordingly.

Comment 1 Martin Kočí 2011-12-15 15:07:54 UTC

I have already reproduced it early this week. And since then I'm opening bug :).  Will create aut. test for that.

Comment 2 Martin Kočí 2011-12-16 19:07:40 UTC

Just a note from testing. 
Hope this is related to this bug. See result from the automatic test from jenkins: http://hudson.rhq.lab.eng.bos.redhat.com:8080/hudson/job/ImageFactory-KocaTesting2/81/console

--truncated---
RuntimeError: mount_options: /dev/vda1 on /boot: mount: you must specify the filesystem type

2011-12-16 13:57:05,385 WARNING oz.Guest.FedoraGuest pid(9848) Message: Failed shutting down guest, forcibly killing
RuntimeError: mount_options: /dev/vda1 on /boot: mount: you must specify the filesystem type
2011-12-16 13:57:15,989 DEBUG imgfac.BuildJob.BuildJob pid(9848) Message: Builder (0c140b57-09f2-47c8-9149-89fa85182ced) changed status from BUILDING to FAILED
RuntimeError: mount_options: /dev/vda1 on /boot: mount: you must specify the filesystem type
--truncated---

(command: imagefactory --debug --target rhevm --template templates/bug768028.tdl)

#grep 'aeolus\|imagefactory-\|oz-\|iwhd'
rubygem-aeolus-cli-0.2.0-2.el6.noarch
aeolus-conductor-doc-0.7.0-4.el6.noarch
rubygem-arel-2.0.10-0.aeolus.el6.noarch
rubygem-rack-mount-0.7.1-3.aeolus.el6.noarch
imagefactory-jeosconf-ec2-fedora-1.0.0rc1-1.el6.noarch
rubygem-imagefactory-console-0.5.0-4.20110824113238gitd9debef.el6.noarch
oz-0.7.9-4.el6.noarch
aeolus-configure-2.4.0-3.el6.noarch
rubygem-aeolus-image-0.2.0-1.el6.noarch
imagefactory-1.0.0rc1-1.el6.noarch
aeolus-conductor-0.7.0-4.el6.noarch
aeolus-all-0.7.0-4.el6.noarch
imagefactory-jeosconf-ec2-rhel-1.0.0rc1-1.el6.noarch
rubygem-ZenTest-4.3.3-2.aeolus.el6.noarch
iwhd-1.1-2.el6.x86_64
aeolus-conductor-daemons-0.7.0-4.el6.noarch

Comment 3 wes hayutin 2012-01-10 17:11:08 UTC

adding to ce-sprint-next

Comment 4 wes hayutin 2012-01-10 17:14:13 UTC

adding to ce-sprint-next

Comment 5 wes hayutin 2012-01-12 16:35:55 UTC

adding to ce-sprint

Comment 6 wes hayutin 2012-01-12 16:42:07 UTC

removing ce-sprint-next tracker

Comment 7 wes hayutin 2012-01-12 16:44:15 UTC

taking off ce-sprint-next..

Comment 8 Ian McLeod 2012-01-17 20:32:25 UTC

Fixed here:

https://github.com/aeolusproject/imagefactory/commit/68a4317d0179911f14d9c61dda662d2870a1d1cc

F16's newer GRUB changes the partition number that contains /boot.

Switching to ON_QA.

Comment 9 Martin Kočí 2012-01-18 12:31:27 UTC

on RHEL62
Test didn't passed with 
imagefactory-1.0.0rc2.1-1.el6.noarch
but it successfully build the F16 image with 
imagefactory-1.0.0rc2_10_gcf8da4e-1.el6.noarch 
with small warning : 
2012-01-18 07:09:04,644 WARNING oz.Guest.FedoraGuest pid(26648) Message: Failed shutting down guest, forcibly killing
For further info see 
http://hudson.rhq.lab.eng.bos.redhat.com:8080/hudson/view/DEV-CloudForms/job/ImageFactory-KocaTesting2/219/console

So if the warning above is not related to this bug, we can move the bug to VERIFIED for 
#rpm -qa |grep 'aeolus\|imagefactory-\|oz-\|iwhd'
rubygem-imagefactory-console-0.5.0-4.20110824113238gitd9debef.el6.noarch
aeolus-configure-2.6.0-0.20120112133633git8701011.el6.noarch
aeolus-conductor-doc-0.9.0-0.20120111153517gite55da85.el6.noarch
imagefactory-jeosconf-ec2-rhel-1.0.0rc2_10_gcf8da4e-1.el6.noarch
rubygem-ZenTest-4.3.3-2.aeolus.el6.noarch
rubygem-aeolus-cli-0.4.0-0.20120111093540git5ec8dc7.el6.noarch
aeolus-conductor-0.9.0-0.20120111153517gite55da85.el6.noarch
iwhd-1.2-3.el6.x86_64
imagefactory-jeosconf-ec2-fedora-1.0.0rc2_10_gcf8da4e-1.el6.noarch
aeolus-conductor-daemons-0.9.0-0.20120111153517gite55da85.el6.noarch
oz-0.8.0-0.20111219203204git5775e9d.el6.noarch
aeolus-all-0.9.0-0.20120111153517gite55da85.el6.noarch
imagefactory-1.0.0rc2_10_gcf8da4e-1.el6.noarch
rubygem-arel-2.0.10-0.aeolus.el6.noarch
rubygem-aeolus-image-0.4.0-0.20120111093551git67fdf6f.el6.noarch

Ian,
the test passed but with warning "2012-01-18 07:09:04,644 WARNING oz.Guest.FedoraGuest pid(26648) Message: Failed shutting down guest, forcibly killing". Can you waived in regards of this bug ? Do you want me to open a new bug for this ?

Comment 10 Martin Kočí 2012-01-18 13:49:46 UTC

On different RHEL62 the test passed without warning..so moving the bug to VERIFIED for imagefactory-1.0.0rc2_10_gcf8da4e-1.el6.noarch