Bug 768406

Summary:	The "monitor_link" ip attribute default is backwards
Product:	Red Hat Enterprise Linux 6	Reporter:	Ryan McCabe <rmccabe>
Component:	luci	Assignee:	Ryan McCabe <rmccabe>
Status:	CLOSED ERRATA	QA Contact:	Cluster QE <mspqa-list>
Severity:	low	Docs Contact:
Priority:	low
Version:	6.2	CC:	cluster-maint, jpokorny, jwest, rsteiger
Target Milestone:	rc	Keywords:	Rebase
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	luci-0.26.0-1.el6	Doc Type:	Rebase: Bug Fixes and Enhancements
Doc Text:	Cause: The default value of the "monitor_link" attribute of the IP resource agent was displayed backwards. When not specified explicitly, its value was displayed as enabled when it was actually disabled, and vice versa. When making changes to the value of "monitor_link" via luci, the incorrect value was stored. Consequence: Users were shown incorrect information about its current state and were not able to modify its value. Fix: Fixes were made to display its value properly and to write its value properly when users changed it. Result: Users can now view and modify the value of the monitor_link attribute of the IP resource agent.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 12:18:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ryan McCabe 2011-12-16 15:16:27 UTC

The "monitor_link" attribute for the IP resource should default to on, not off. When the box is unchecked, monitor_link="0" should be written.

Comment 1 Ryan McCabe 2011-12-16 15:17:02 UTC

Fixed in upstream git commit 96c7e41ec2bfcec3f12efcd0aaed1c299bf32f28

Comment 3 Lon Hohberger 2012-01-30 18:33:35 UTC

luci-0.26.0-1.el6.x86_64

* I added a service with an IP and unchecked 'Monitor Link'
  Resulting cluster.conf line:
    <ip address="172.33.33.1" monitor_link="0" sleeptime="10"/>
  PASS

* I checked different pages, then back to edit the service, and 'Monitor Link' was still unchecked.
  PASS

* I edited the service and checked the monitor_link box.
  Resulting cluster.conf line:
    <ip address="172.33.33.1" sleeptime="10"/>
  PASS

* I checked different pages again, then back to edit the service, and 'Monitor Link' was still checked.
  PASS

Comment 6 Ryan McCabe 2012-04-12 03:58:31 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: The default value of the "monitor_link" attribute of the IP resource agent was displayed backwards. When not specified explicitly, its value was displayed as enbabled when it was actually disabled, and vice versa. When making changes to the value of "monitor_link" via luci, the incorrect value was stored.

Consequence: Users were shown incorrect information about its current state and were not able to modify its value.

Change: Fixes were made to display its value properly and to write its value properly when users changed it.

Result: Users can now view and modify the value of the monitor_link attribute of the IP resource agent.

Comment 7 Ryan McCabe 2012-04-12 04:23:51 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -2,6 +2,6 @@
 
 Consequence: Users were shown incorrect information about its current state and were not able to modify its value.
 
-Change: Fixes were made to display its value properly and to write its value properly when users changed it.
+Fix: Fixes were made to display its value properly and to write its value properly when users changed it.
 
 Result: Users can now view and modify the value of the monitor_link attribute of the IP resource agent.

Comment 8 Jan Pokorný [poki] 2012-04-12 14:05:23 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,4 +1,4 @@
-Cause: The default value of the "monitor_link" attribute of the IP resource agent was displayed backwards. When not specified explicitly, its value was displayed as enbabled when it was actually disabled, and vice versa. When making changes to the value of "monitor_link" via luci, the incorrect value was stored.
+Cause: The default value of the "monitor_link" attribute of the IP resource agent was displayed backwards. When not specified explicitly, its value was displayed as enabled when it was actually disabled, and vice versa. When making changes to the value of "monitor_link" via luci, the incorrect value was stored.
 
 Consequence: Users were shown incorrect information about its current state and were not able to modify its value.

Comment 10 errata-xmlrpc 2012-06-20 12:18:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0766.html

Comment 11 Ryan McCabe 2012-07-27 19:37:38 UTC

*** Bug 773393 has been marked as a duplicate of this bug. ***