Bug 768514

Summary:	Clickbuttons other than left click not working due to incorrect detection of right button with Elantech clickpads
Product:	[Fedora] Fedora	Reporter:	Veit Wahlich <cru>
Component:	xorg-x11-drv-synaptics	Assignee:	Peter Hutterer <peter.hutterer>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	16	CC:	bugzilla, nsoranzo, peter.hutterer
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-05-30 13:15:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Veit Wahlich 2011-12-16 21:03:01 UTC

Description of problem:
Recent revisions of Samsung's Series9 900X3A notebooks come with an Elantech 
clickpad instead of Synaptics.
With the Elantech touchpad, now a right button is detected although it does not exist. From /var/log/Xorg.0.log:

[     8.617] (--) synaptics: ETPS/2 Elantech Touchpad: buttons: left right double triple

Version-Release number of selected component (if applicable):
1.5.0-2.fc16
1.5.99-2.20111110.fc17 (from rawhide)

How reproducible:
Always.

Steps to Reproduce:
1. Start X on a recent Samsung 900X3A with Elantech clickpad.
  
Actual results:
No matter how many fingers to use when clicking, always "left clicks" are performed.

Expected results:
When clicking with 2 fingers, a right click shall be performed.
When clicking with 3 fingers, a middle click shall be performed.

Additional info:

Comment 1 Veit Wahlich 2011-12-18 22:52:34 UTC

For my fellow sufferers; the following xorg configuration sniplet (to be placed in e.g. /etc/X11/xorg.conf.d/01-synaptics.conf) works around the problem and restores the funcionality:

Section "InputClass"
	Identifier "touchpad catchall"
	Driver "synaptics"
	MatchIsTouchpad "on"
	MatchDevicePath "/dev/input/event*"
	Option "SHMConfig" "on"
	Option "ClickFinger2" "3"
	Option "ClickFinger3" "2"
EndSection

Comment 2 Samuel Jones 2012-03-04 01:26:24 UTC

It appears Chase Douglas has pushed some patches for clickpads recently 

http://lists.x.org/archives/xorg-devel/2012-March/029609.html

Quote: * Multiple soft button implementation fixes from review of previous patch.

Comment 3 Samuel Jones 2012-03-06 18:47:47 UTC

(In reply to comment #2)
> It appears Chase Douglas has pushed some patches for clickpads recently 
> 
> http://lists.x.org/archives/xorg-devel/2012-March/029609.html
> 
> Quote: * Multiple soft button implementation fixes from review of previous
> patch.

I've applied cadouglas patches to the latest git version of xf86-input-synaptic and can confirm that ClickFinger1 and 2 now work (Clicking the Pad with two fingers does a right click) once you set ClickFinger2=3 in synclient or xorg conf

Comment 4 Nicola Soranzo 2012-03-14 11:13:25 UTC

ClickPad support has been merged in xf86-input-synaptics 1.5.99.901

http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/

Comment 5 Peter Hutterer 2012-03-14 22:06:09 UTC

here's a scratch build for 1.5.99.901 on f16, can you please test this? I usually avoid updating driver major versions in releases but I think this time its worth it.

http://koji.fedoraproject.org/koji/taskinfo?taskID=3895383

Comment 6 Nicola Soranzo 2012-03-16 22:44:48 UTC

(In reply to comment #5)
> here's a scratch build for 1.5.99.901 on f16, can you please test this? I
> usually avoid updating driver major versions in releases but I think this time
> its worth it.
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3895383

I've installed this scratch build rpm but the right button of the clickpad is not recognized yet, it keeps working as a left button.
My netbook is a HP Mini 210-1040sl.
I can provide logs or do other tests if needed.

Comment 7 Peter Hutterer 2012-03-19 21:38:37 UTC

I should have mentioned that, sorry. We don't enable the soft buttons for right/middle click by default yet, I ran into some issues with this. The SoftButtonAreas option (see the man page) does that though, but for now you'll have to set it manually.

Comment 8 Nicola Soranzo 2012-03-23 13:56:21 UTC

(In reply to comment #7)
> I should have mentioned that, sorry. We don't enable the soft buttons for
> right/middle click by default yet, I ran into some issues with this. The
> SoftButtonAreas option (see the man page) does that though, but for now you'll
> have to set it manually.

Ok, thanks!
I see that in the mean time you released version 1.5.99.902, which seems to have SoftButtonAreas autoconfigured. If you can provide a new scratch build for F16, I can test it!

Comment 9 Peter Hutterer 2012-04-20 03:26:13 UTC

sorry, after looking at this yesterday we won't be able to backport this to F16. It requires a few multitouch bits and the backport would be more effort that I have time for atm.

This should be fixed in F17 though.

Comment 10 Nicola Soranzo 2012-05-30 13:15:31 UTC

(In reply to comment #9)
> sorry, after looking at this yesterday we won't be able to backport this to
> F16. It requires a few multitouch bits and the backport would be more effort
> that I have time for atm.
> 
> This should be fixed in F17 though.

I can confirm that after upgrading to F17 the right click button works as expected!

Per your comment, I'm closing this bug as NEXTRELEASE.