Bug 768545

I'm done with the review.  All looks good except the license.  I see no references to GPLv2 or BSD.  What am I missing?

Good catch - I took the spec file from upstream old release. 

The code (with one exception) is licensed under the three-clause BSD license, and is noted at the beginning of each source file. 

There is a small section of code that is licensed LGPLv2+. 

I've changed the license section to reflect this. 

SPEC URL: http://ke4qqq.fedorapeople.org/blktap.spec
SRPM URL: http://ke4qqq.fedorapeople.org/blktap-2.0.90-2.git20111216.62de90d.fc16.src.rpm

OK    MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1]
blktap.src: W: summary-not-capitalized C blktap user space utilities
blktap.src: W: name-repeated-in-summary C blktap
blktap.src: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace
blktap.src: W: invalid-url Source0: xen-org-blktap-62de80d.tar.gz
blktap.spec: W: invalid-url Source0: xen-org-blktap-62de80d.tar.gz
1 packages and 1 specfiles checked; 0 errors, 5 warnings.

OK    MUST: The package must be named according to the Package Naming Guidelines .
OK    MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] .
OK    MUST: The package must meet the Packaging Guidelines .
OK    MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK    MUST: The License field in the package spec file must match the actual license. [3]
NA    MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4]
OK    MUST: The spec file must be written in American English. [5]
OK    MUST: The spec file for the package MUST be legible. [6]
OK    MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
OK    MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7]
NA    MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8]
OK    MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK    MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
OK    MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10]
OK    MUST: Packages must NOT bundle copies of system libraries.[11]
NA    MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12]
OK    MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13]
OK    MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14]
OK    MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15]
OK    MUST: Each package must consistently use macros. [16]
OK    MUST: The package must contain code, or permissable content. [17]
NA    MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18]
OK    MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18]
NA    MUST: Header files must be in a -devel package. [19]
NA    MUST: Static libraries must be in a -static package. [20]
NA    MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19]
NA    MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [21]
NA    MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[20]
NA    MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22]
OK    MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23]
OK    MUST: All filenames in rpm packages must be valid UTF-8. [24]

FAIL    SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [25]
FAIL    SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [26]
OK    SHOULD: The reviewer should test that the package builds in mock. [27]
NA    SHOULD: The package should compile and build into binary rpms on all supported architectures. [28]
NA    SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
NA    SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [29]
NA    SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [21]
NA    SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [30]
NA    SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [31]
FAIL    SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.[32]

(In reply to comment #3)
> FAIL    SHOULD: If the source package does not include license text(s) as a
> separate file from upstream, the packager SHOULD query upstream to include it.
> [25]

https://github.com/xen-org/blktap/issues/1  
Done

> FAIL    SHOULD: The description and summary sections in the package spec file
> should contain translations for supported Non-English languages, if available.
> [26]

There's no i18n support in this, so NA IMO. - moreover, I can't translate to anything. 


> FAIL    SHOULD: your package should contain man pages for binaries/scripts. If
> it doesn't, work with upstream to add them where they make sense.[32]

I requested that upstream should create said man pages here:
https://github.com/xen-org/blktap/issues/2

In addition I discovered that libtool archives were being built and packaged. I stripped these from the -devel package.  

New SPEC: http://ke4qqq.fedorapeople.org/blktap.spec
New SRPM: http://ke4qqq.fedorapeople.org/blktap-2.0.90-2.git20111216.62de90d.fc16.src.rpm

Eric - I see that you flagged this as fedora-review+ - does that mean you approved, or just a mis-selection?

David - The only 'failures' were on the SHOULDs and thus not required.  The review is approved.  Go forth and prosper.

New Package SCM Request
=======================
Package Name: blktap
Short Description: blktap user space utilities
Owners: ke4qqq
Branches: f15 el6
InitialCC:

Git done (by process-git-requests).

Package Change Request
======================
Package Name: blktap
New Branches: f16
Owners: ke4qqq

[typo excluded f16, sorry about that]

Git done (by process-git-requests).

blktap-2.0.90-3.git20111216.62de90d.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/blktap-2.0.90-3.git20111216.62de90d.fc16

blktap-2.0.90-3.git20111216.62de90d.fc16 has been pushed to the Fedora 16 testing repository.

Closing, this is already in Fedora since 17.