| Summary: | Review Request: libwacom - Tablet Information Client Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Hutterer <peter.hutterer> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bnocera, mclasen, notting, package-review |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libwacom-0.1-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-23 07:58:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Peter Hutterer
2011-12-19 01:27:50 UTC
builds fine in mock, rpmlint says: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm 5 packages and 0 specfiles checked; 0 errors, 0 warnings. package name: ok
spec file name: ok
packaging guidelines: generally, ok. some minor cleanups possible:
- BuildRoot: is no longer needed
- rm -rf %{buildroot} in %install no longer needed
- %clean no longer needed
fine to leave these things in place if you want to minimize spec file changes
for building on e.g. RHEL
license: ok
license: field ok
license file: ok
spec language: ok
spec readable: ok
upstream sources: ok
buildable: ok
ExcludeArch: ok
BuildRequires: ok
locale handling: ok
ldconfig: ok
system libs: ok
relocatable: ok
directory ownership: looks like you need to own
%{_datadir}/libwacom
%{_includedir}/libwacom-1.0
%{_includedir}/libwacom-1.0/libwacom
duplicate files: ok
file permissions: ok
macro use: ok
content: ok
large docs: ok
%doc content: ok
headers: ok
static libs: ok
shared libs: ok
devel dep: ok
libtool archives: ok
gui apps: ok
file ownership: ok
utf8 filenames: ok
Summary: fix directory ownership, then it is good to go
(In reply to comment #2) > packaging guidelines: generally, ok. some minor cleanups possible: > - BuildRoot: is no longer needed > - rm -rf %{buildroot} in %install no longer needed > - %clean no longer needed all three removed > directory ownership: looks like you need to own > %{_datadir}/libwacom > %{_includedir}/libwacom-1.0 > %{_includedir}/libwacom-1.0/libwacom added to the devel/data packages as required. update spec/srpm available at URL above Looks all good now. Approved New Package SCM Request ======================= Package Name: libwacom Short Description: Tablet Information Client Library Owners: whot hadess Branches: f16 InitialCC: Git done (by process-git-requests). Matthias, please take ownership of review BZs. Thanks! libwacom-0.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libwacom-0.1-1.fc16 libwacom-0.1-1.fc16 has been pushed to the Fedora 16 stable repository. |